Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert thrifty-runtime to kotlin, require Java 8 #391

Merged
merged 4 commits into from
Aug 24, 2020

Conversation

benjamin-bader
Copy link
Collaborator

Closes #387
Closes #388

@benjamin-bader
Copy link
Collaborator Author

Breaking change: callbacks for oneway service methods now take Unit, not Void.

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2020

Codecov Report

Merging #391 into master will decrease coverage by 1.52%.
The diff coverage is 71.02%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #391      +/-   ##
============================================
- Coverage     62.85%   61.33%   -1.53%     
+ Complexity     1116     1039      -77     
============================================
  Files            83       84       +1     
  Lines          7000     6711     -289     
  Branches       1004     1011       +7     
============================================
- Hits           4400     4116     -284     
+ Misses         2258     2251       -7     
- Partials        342      344       +2     
Impacted Files Coverage Δ Complexity Δ
...kotlin/com/microsoft.thrifty.gen/ServiceBuilder.kt 0.45% <0.00%> (ø) 1.00 <0.00> (ø)
.../com/microsoft/thrifty/kgen/KotlinCodeGenerator.kt 81.28% <0.00%> (ø) 135.00 <0.00> (ø)
...ime/src/main/kotlin/com/microsoft/thrifty/TType.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...tlin/com/microsoft/thrifty/service/TMessageType.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...kotlin/com/microsoft/thrifty/service/MethodCall.kt 33.33% <33.33%> (ø) 2.00 <2.00> (?)
...kotlin/com/microsoft/thrifty/service/ClientBase.kt 49.05% <49.05%> (ø) 7.00 <7.00> (?)
.../com/microsoft/thrifty/protocol/MessageMetadata.kt 50.00% <50.00%> (ø) 1.00 <1.00> (?)
...com/microsoft/thrifty/transport/BufferTransport.kt 50.00% <50.00%> (ø) 3.00 <3.00> (?)
...n/com/microsoft/thrifty/service/AsyncClientBase.kt 55.55% <55.55%> (ø) 7.00 <7.00> (?)
...m/microsoft/thrifty/protocol/SimpleJsonProtocol.kt 65.38% <65.38%> (ø) 25.00 <25.00> (?)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a7d7aa...19de415. Read the comment docs.

@benjamin-bader
Copy link
Collaborator Author

More breaking changes:

  • Protocol is now an interface
  • Transport is now an interface

@benjamin-bader benjamin-bader merged commit 5a7f320 into microsoft:master Aug 24, 2020
@benjamin-bader benjamin-bader deleted the kotlin-runtime branch August 24, 2020 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require Java 8 Move to 100% Kotlin
2 participants