Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated JvmDefault annotations #481

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

benjamin-bader
Copy link
Collaborator

See:
https://kotlinlang.org/docs/whatsnew15.html#deprecation-of-jvmdefault-and-old-xjvm-default-modes

This one's subtle and might require a major-version bump. TL;DR is that prior to 1.5, Kotlin did some ABI-level things to support calling default methods in Kotlin interfaces from Java. The deprecation involves switching a compiler setting, which will change the nature of the ABI a little bit. The next release won't be a drop-in replacement; calling code will also potentially need recompilation.

That said, Android apps are always recompiled so maybe it's not the breaking change it could be.

@codecov-commenter
Copy link

Codecov Report

Merging #481 (04334b6) into master (9747f7d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #481   +/-   ##
=========================================
  Coverage     58.87%   58.87%           
- Complexity      862      864    +2     
=========================================
  Files            69       69           
  Lines          6451     6451           
  Branches       1005     1004    -1     
=========================================
  Hits           3798     3798           
  Misses         2360     2360           
  Partials        293      293           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9747f7d...04334b6. Read the comment docs.

@benjamin-bader benjamin-bader merged commit d7d0998 into microsoft:master Apr 15, 2022
@benjamin-bader benjamin-bader deleted the remove-jvmdefault branch April 15, 2022 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants