-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SSL issue with EuroSAT #1065
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change https to http as the source SSL certificat is note valid anymore
@adamjstewart any reason why we shouldn't switch to http until EuroSAT figures their cert out? |
Not that I can think of. Just to be safe, let's change checksum to default to True until https is working again. |
calebrob6
previously approved these changes
Jan 30, 2023
calebrob6
approved these changes
Jan 30, 2023
adamjstewart
approved these changes
Jan 30, 2023
Confirmed that the MD5 hasn't changed. |
adamjstewart
added a commit
that referenced
this pull request
Jan 31, 2023
This reverts commit 8513796.
adamjstewart
added a commit
that referenced
this pull request
Feb 1, 2023
calebrob6
added a commit
that referenced
this pull request
Apr 10, 2023
* Fix SSL issue with EuroSAT Change https to http as the source SSL certificat is note valid anymore * Add todos and checksum default * flake8 --------- Co-authored-by: Caleb Robinson <calebrob6@gmail.com>
calebrob6
pushed a commit
that referenced
this pull request
Apr 10, 2023
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
* Fix SSL issue with EuroSAT Change https to http as the source SSL certificat is note valid anymore * Add todos and checksum default * flake8 --------- Co-authored-by: Caleb Robinson <calebrob6@gmail.com>
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
* Revert "Fix SSL issue with EuroSAT (microsoft#1065)" This reverts commit 8513796. * EuroSAT: redistribute on Hugging Face
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change https to http as the source SSL certificate is not valid anymore
Fixes #1064