Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSL issue with EuroSAT #1065

Merged
merged 3 commits into from
Jan 30, 2023
Merged

Conversation

julien-blanchon
Copy link
Contributor

@julien-blanchon julien-blanchon commented Jan 30, 2023

Change https to http as the source SSL certificate is not valid anymore

Fixes #1064

Change https to http as the source SSL certificat is note valid anymore
@github-actions github-actions bot added the datasets Geospatial or benchmark datasets label Jan 30, 2023
@calebrob6
Copy link
Member

@adamjstewart any reason why we shouldn't switch to http until EuroSAT figures their cert out?

@adamjstewart
Copy link
Collaborator

Not that I can think of. Just to be safe, let's change checksum to default to True until https is working again.

@adamjstewart adamjstewart added this to the 0.4.1 milestone Jan 30, 2023
calebrob6
calebrob6 previously approved these changes Jan 30, 2023
@adamjstewart
Copy link
Collaborator

Confirmed that the MD5 hasn't changed.

@adamjstewart adamjstewart merged commit 8513796 into microsoft:main Jan 30, 2023
adamjstewart added a commit that referenced this pull request Jan 31, 2023
adamjstewart added a commit that referenced this pull request Feb 1, 2023
* Revert "Fix SSL issue with EuroSAT (#1065)"

This reverts commit 8513796.

* EuroSAT: redistribute on Hugging Face
calebrob6 added a commit that referenced this pull request Apr 10, 2023
* Fix SSL issue with EuroSAT

Change https to http as the source SSL certificat is note valid anymore

* Add todos and checksum default

* flake8

---------

Co-authored-by: Caleb Robinson <calebrob6@gmail.com>
calebrob6 pushed a commit that referenced this pull request Apr 10, 2023
* Revert "Fix SSL issue with EuroSAT (#1065)"

This reverts commit 8513796.

* EuroSAT: redistribute on Hugging Face
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
* Fix SSL issue with EuroSAT

Change https to http as the source SSL certificat is note valid anymore

* Add todos and checksum default

* flake8

---------

Co-authored-by: Caleb Robinson <calebrob6@gmail.com>
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
* Revert "Fix SSL issue with EuroSAT (microsoft#1065)"

This reverts commit 8513796.

* EuroSAT: redistribute on Hugging Face
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Geospatial or benchmark datasets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EuroSAT Dataset URL not being secure anymore
3 participants