Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL4EO-L Weights #1482

Merged
merged 19 commits into from
Sep 30, 2023
Merged

Conversation

nilsleh
Copy link
Collaborator

@nilsleh nilsleh commented Jul 17, 2023

This PR adds the SSL4EO-L Weights as Enums

@github-actions github-actions bot added the models Models and pretrained weights label Jul 17, 2023
@nilsleh nilsleh marked this pull request as draft July 17, 2023 10:07
@nilsleh
Copy link
Collaborator Author

nilsleh commented Jul 17, 2023

@adamjstewart I just added a couple to see if the formatting and naming etc is okay, before adding the rest.

@adamjstewart
Copy link
Collaborator

I'm thinking we should have a single repo on HF for all Landsat weights. What do you think?

@adamjstewart
Copy link
Collaborator

Trying to decide if we should rename our model repo to ssl4eo_l or our dataset repo to ssl4eo_landsat. What do you think?

@nilsleh
Copy link
Collaborator Author

nilsleh commented Jul 20, 2023

I feel like ssl4eo_landsat is a lot more clear and worth the extra characters, I didn't think about it when creating the HF repo, just thought it would be the clearest description

@adamjstewart
Copy link
Collaborator

Alright, let's go with that then. Naming looks good here so you can upload the rest of the weights. I'm not exactly sure how the U-Net weights work, but we want those too.

We can submit a separate PR to rename the HF repos for the datasets. For the existing weights, I would like to organize them like we do here, but the difference is that we can't delete the old names (at least for some time) since older releases depend on those names.

@adamjstewart adamjstewart added this to the 0.5.0 milestone Sep 7, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 28, 2023
@nilsleh nilsleh marked this pull request as ready for review September 28, 2023 15:32
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not have any U-Net pre-trained weights we can upload? We at least have the cloud cover models on our cluster. Not sure if the framework is in place to load those weights though...

docs/api/resnet_pretrained_weights.csv Outdated Show resolved Hide resolved
docs/api/resnet_pretrained_weights.csv Outdated Show resolved Hide resolved
torchgeo/models/resnet.py Outdated Show resolved Hide resolved
torchgeo/models/resnet.py Show resolved Hide resolved
torchgeo/models/resnet.py Show resolved Hide resolved
@github-actions github-actions bot added the testing Continuous integration testing label Sep 30, 2023
@adamjstewart
Copy link
Collaborator

None of the weights are in the right format...

missing_keys = ['cls_token', 'pos_embed', 'patch_embed.proj.weight', 'patch_embed.proj.bias', 'blocks.0.norm1.weight', 'blocks.0.norm1.bias', ...]
unexpected_keys = ['state_dict', 'hyper_parameters']

@adamjstewart adamjstewart merged commit 18139b4 into microsoft:main Sep 30, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation models Models and pretrained weights testing Continuous integration testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants