Fix trainer support for datasets without a plot method #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I no longer have this issue, thanks. |
calebrob6
force-pushed
the
fixes/no-dataset-plot
branch
from
7d4544e
to
082c28d
Compare
|
Datamodule.plot returns an |
calebrob6
approved these changes
Sep 25, 2023
|
I'll consider this as proper testing 😄 |
|
😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1551. See #1487 for discussion.
@gtgrp-user can you confirm this solves your issue? I never figured out how to test this in CI but it's obviously a bug and the fix is pretty simple.