Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GlobBiomass: several bug fixes #2086

Merged
merged 2 commits into from
May 25, 2024

Conversation

adamjstewart
Copy link
Collaborator

@adamjstewart adamjstewart commented May 25, 2024

This PR fixes the following bugs:

  • GlobBiomass data is from 2010, although it isn't in the filename
  • Mask is for pixelwise regression, use float32, not long
  • Length of dataset was doubled due to unspecific filename_glob

I also improved the documentation to include definitions and units of AGB and GSV.

I didn't do these in this PR, but some suggestions for future contributions to this dataset:

  • Add download support, URLs are public
  • Add support for file extensions other than .tif
  • Split estimation mask and uncertainty mask into two different dict keys (backwards incompatible)
  • Treat measurements like bands and allow return both
  • Treat measurements AND errors like bands and allow return both
  • Add data module, our first real pixelwise regression dataset

@adamjstewart adamjstewart added this to the 0.5.3 milestone May 25, 2024
@github-actions github-actions bot added datasets Geospatial or benchmark datasets testing Continuous integration testing labels May 25, 2024
torchgeo/datasets/globbiomass.py Outdated Show resolved Hide resolved
@adamjstewart adamjstewart merged commit a87eadb into microsoft:main May 25, 2024
19 checks passed
@adamjstewart adamjstewart deleted the datasets/globbiomass branch May 25, 2024 20:41
@adamjstewart adamjstewart modified the milestones: 0.5.3, 0.6.0 Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Geospatial or benchmark datasets testing Continuous integration testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants