VectorDataset: fix issue with empty query #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
datasets
|
It does for #399 . |
|
This fixes my issue in #454 too. Thank you! |
adamjstewart
added a commit
that referenced
this pull request
Mar 19, 2022
* VectorDataset: fix issue with empty query * isort
remtav
pushed a commit
to remtav/torchgeo
that referenced
this pull request
May 26, 2022
* VectorDataset: fix issue with empty query * isort
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
* VectorDataset: fix issue with empty query * isort
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just because a query is within the overall bounds of a dataset doesn't mean that it contains 1 or more shape features. This PR returns an empty tensor using the same default fill value and dtype as
rasterize.Fixes #399
Fixes #454
@nilsleh @evu can you test this and make sure it solves your issues?