Fix PyTorch Lightning 1.6 type hints #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing
calebrob6
approved these changes
Mar 30, 2022
isaaccorley
approved these changes
Mar 30, 2022
remtav
pushed a commit
to remtav/torchgeo
that referenced
this pull request
May 26, 2022
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyTorch Lightning 1.6.0 was released today and includes better type hints, causing our mypy tests to fail. This PR updates some things related to PL 1.6.
The reason that these type ignores are needed (and the try-except is needed) is that all model/datamodule/trainer attributes are optional. We could instead replace the try-except with a
hasattr(...)for literally every attribute, but that gets cumbersome pretty quickly. I may do this in the future, but for now, the try-except protects us.