Fix data casting for the SEN12MS dataset #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khdlr
force-pushed
the
fix_sen12ms_datatypes
branch
from
d7a244d
to
905aa7f
Compare
adamjstewart
approved these changes
Apr 9, 2022
There was a problem hiding this comment.
I believe this is the correct approach, and matches how we handle arbitrary GeoDatasets: https://github.com/microsoft/torchgeo/blob/v0.2.1/torchgeo/datasets/geo.py#L466,L470
Is this still WIP or is it ready to be merged?
adamjstewart
changed the title
remtav
pushed a commit
to remtav/torchgeo
that referenced
this pull request
May 26, 2022
Merged
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #500, not 100% sure yet whether this fix is the one we want. Feedback much appreciated!