Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data casting for the SEN12MS dataset #502

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

khdlr
Copy link
Contributor

@khdlr khdlr commented Apr 6, 2022

Fixes #500, not 100% sure yet whether this fix is the one we want. Feedback much appreciated!

@github-actions github-actions bot added the datasets Geospatial or benchmark datasets label Apr 6, 2022
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is the correct approach, and matches how we handle arbitrary GeoDatasets: https://github.com/microsoft/torchgeo/blob/v0.2.1/torchgeo/datasets/geo.py#L466,L470

Is this still WIP or is it ready to be merged?

@adamjstewart adamjstewart added this to the 0.2.2 milestone Apr 9, 2022
@adamjstewart adamjstewart changed the title [WIP] Fix data casting for the SEN12MS dataset Fix data casting for the SEN12MS dataset Apr 11, 2022
@adamjstewart adamjstewart merged commit 4aeacb9 into microsoft:main Apr 11, 2022
remtav pushed a commit to remtav/torchgeo that referenced this pull request May 26, 2022
@adamjstewart adamjstewart modified the milestones: 0.2.2, 0.3.0 Jul 2, 2022
@adamjstewart adamjstewart mentioned this pull request Jul 11, 2022
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Geospatial or benchmark datasets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datasets.SEN12MS - dB values are cast to int32
2 participants