Add arith.addi reduction
#20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
makslevental
force-pushed
the
reduce_addi
branch
from
5061ff6
to
8e31bf1
Compare
Closed
makslevental
force-pushed
the
reduce_addi
branch
from
8e31bf1
to
1e6c7f1
Compare
|
@makslevental thanks! |
|
@makslevental , looks like your new test is failing. Please take a look. |
|
Thanks @makslevental for the help! Code changes look good to me. Just need to fix the lit test and we're good to go. :) |
makslevental
force-pushed
the
reduce_addi
branch
3 times, most recently
from
35b8a64
to
f5f0b22
Compare
makslevental
force-pushed
the
reduce_addi
branch
from
f5f0b22
to
9d5f3bf
Compare
nhat-nguyen
approved these changes
Oct 17, 2023
|
Thanks @makslevental! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12. Happy to add more tests if you'd like.