Move serialization constructors and raw field #3414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
|
API change check APIView has identified API level changes in this PR and created following API reviews. Microsoft.Generator.CSharp |
jorgerangel-msft
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
jorgerangel-msft
requested review from
ArcturusZhang,
ShivangiReja,
JoshLove-msft and
m-nash
...ient-csharp/generator/Microsoft.Generator.CSharp/test/Models/Types/ModelTypeProviderTests.cs
Show resolved
Hide resolved
m-nash
reviewed
May 22, 2024
...tp-client-csharp/generator/Microsoft.Generator.CSharp/src/OutputTypes/PropertyDeclaration.cs
Outdated
Show resolved
Hide resolved
...tp-client-csharp/generator/Microsoft.Generator.CSharp/src/OutputTypes/PropertyDeclaration.cs
Outdated
Show resolved
Hide resolved
...ator/Microsoft.Generator.CSharp.ClientModel/src/Models/Types/MrwSerializationTypeProvider.cs
Outdated
Show resolved
Hide resolved
...ator/Microsoft.Generator.CSharp.ClientModel/src/Models/Types/MrwSerializationTypeProvider.cs
Outdated
Show resolved
Hide resolved
...nt-csharp/generator/Microsoft.Generator.CSharp.ClientModel/src/Utilities/StringExtensions.cs
Outdated
Show resolved
Hide resolved
...nt-csharp/generator/Microsoft.Generator.CSharp.ClientModel/src/Utilities/StringExtensions.cs
Outdated
Show resolved
Hide resolved
...http-client-csharp/generator/Microsoft.Generator.CSharp/src/OutputTypes/ModelTypeProvider.cs
Outdated
Show resolved
Hide resolved
...generator/TestProjects/Local/Unbranded-TypeSpec/src/Generated/Models/Friend.Serialization.cs
Outdated
Show resolved
Hide resolved
...rp/generator/Microsoft.Generator.CSharp.ClientModel/src/Models/PropertyDescriptionBuilder.cs
Outdated
Show resolved
Hide resolved
...rp/generator/Microsoft.Generator.CSharp.ClientModel/src/Models/PropertyDescriptionBuilder.cs
Outdated
Show resolved
Hide resolved
...tp-client-csharp/generator/Microsoft.Generator.CSharp/src/OutputTypes/PropertyDeclaration.cs
Outdated
Show resolved
Hide resolved
...generator/TestProjects/Local/Unbranded-TypeSpec/src/Generated/Models/Friend.Serialization.cs
Show resolved
Hide resolved
m-nash
reviewed
May 24, 2024
packages/http-client-csharp/generator/Microsoft.Generator.CSharp.sln
Outdated
Show resolved
Hide resolved
...tp-client-csharp/generator/Microsoft.Generator.CSharp/src/OutputTypes/PropertyDeclaration.cs
Outdated
Show resolved
Hide resolved
packages/http-client-csharp/generator/Microsoft.Generator.CSharp.Shared/src/StringExtensions.cs
Outdated
Show resolved
Hide resolved
m-nash
reviewed
Jun 3, 2024
...ator/Microsoft.Generator.CSharp.ClientModel/src/Models/Types/MrwSerializationTypeProvider.cs
Show resolved
Hide resolved
...t-csharp/generator/Microsoft.Generator.CSharp/src/Expressions/FormattableStringExpression.cs
Outdated
Show resolved
Hide resolved
...ttp-client-csharp/generator/Microsoft.Generator.CSharp/src/Microsoft.Generator.CSharp.csproj
Outdated
Show resolved
Hide resolved
packages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/OutputTypes/Parameter.cs
Outdated
Show resolved
Hide resolved
m-nash
reviewed
Jun 3, 2024
...ator/Microsoft.Generator.CSharp.ClientModel/src/Models/Types/MrwSerializationTypeProvider.cs
Outdated
Show resolved
Hide resolved
...ator/Microsoft.Generator.CSharp.ClientModel/src/Models/Types/MrwSerializationTypeProvider.cs
Outdated
Show resolved
Hide resolved
packages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/OutputTypes/CSharpType.cs
Outdated
Show resolved
Hide resolved
packages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/OutputTypes/Parameter.cs
Outdated
Show resolved
Hide resolved
packages/http-client-csharp/generator/Microsoft.Generator.CSharp/test/Mocks/MockTypeFactory.cs
Outdated
Show resolved
Hide resolved
m-nash
approved these changes
Jun 3, 2024
...s/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Providers/ParameterProvider.cs
Show resolved
Hide resolved
...http-client-csharp/generator/Microsoft.Generator.CSharp.ClientModel/src/ClientModelPlugin.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the construction of the existing serialization constructors for a model to the MrwSerializationTypeProvider class. With this change, all serialization related code is generated with a models serialization class file. It also adds the support for generating an additional constructor to deserialize into a model with an additional raw data parameter.