Upgrade android jsi headers to 0.71-stable #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mganandraj
reviewed
Jan 4, 2023
mganandraj
reviewed
Jan 4, 2023
mganandraj
reviewed
Jan 4, 2023
android/V8Runtime_shared.cpp
Outdated
| } | ||
|
|
||
| std::shared_ptr<jsi::NativeState> V8Runtime::getNativeState(const jsi::Object& obj) { | ||
| std::shared_ptr<jsi::NativeState>* holder = static_cast<std::shared_ptr<jsi::NativeState>*>(objectRef(obj)->GetAlignedPointerFromInternalField(0)); |
There was a problem hiding this comment.
https://v8docs.nodesource.com/node-0.12/db/d85/classv8_1_1_object.html#a580ea84afb26c005d6762eeb9e3c308f sounds like if it isn't set, it is undefined behavior. I don't know how we would know if it was set.
There was a problem hiding this comment.
we will definitely need to revisit the 0.71 implementation... for now I'm just getting it compiling to unblock the rn bump.
mganandraj
reviewed
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null
Microsoft Reviewers: Open in CodeFlow