-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional logging and defenses to artifacts use. #947
Conversation
Hopefully helps run down what's happening in microsoft/vcpkg#30051
src/vcpkg/base/hash.cpp
Outdated
|
||
if (!ec) | ||
auto result_hash = hasher.get_hash(); | ||
if (Debug::g_debugging) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this if statement, Debug::print
should already check if we are in debug mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was done to avoid the cost of the format
but that's premature, yes.
* Fix setting VCPKG_ROOT broken in #947 * Update scripts sha and add release checklist for VS.
I don't know if this was intentional but this changed the output from
to
which is also shown to use users in case of a hash mismatch. |
Should fix microsoft/vcpkg#26172
Helps debug microsoft/vcpkg#30051