Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSBuild integration: "Using triplet" message has high importance #12164

Closed
gix opened this issue Jun 30, 2020 · 1 comment · Fixed by #12212
Closed

MSBuild integration: "Using triplet" message has high importance #12164

gix opened this issue Jun 30, 2020 · 1 comment · Fixed by #12212
Assignees
@PhoebeHui
Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed

Comments

@gix
Copy link
Contributor

gix commented Jun 30, 2020

Describe the bug
vcpkg's msbuild integration (in vcpkg.targets) displays a message Using triplet "x64-windows" from "<vcpkg-root>". Since #4361 this message has importance high (instead of the previous normal) which results in a lot of unnecessary build output. This change seems like a forgotten debugging aid missed in the review.

To Reproduce
Steps to reproduce the behavior:

  1. vcpkg install and export any port as nuget.
  2. Add the nuget package to a C++ project in Visual Studio.
  3. Build with the default MSBuild verbosity (Minimal).

Expected behavior
No message.
@PhoebeHui
Copy link
Contributor

@gix, thanks for reporting this issue!

For me, I'm okay to change the 'High' to 'Normal' in https://github.com/microsoft/vcpkg/blob/master/scripts/buildsystems/msbuild/vcpkg.targets#L90, and it will give message when the output set to 'Normal' or higher, reference from verbosity-settings

@Neumann-A, what do you think?

@PhoebeHui PhoebeHui added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Jul 1, 2020
@PhoebeHui PhoebeHui mentioned this issue Jul 2, 2020
Merged
@gix gix mentioned this issue Aug 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhoebeHui PhoebeHui

Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[msbuild] Revert the importance to Normal PhoebeHui/vcpkg
2 participants
@gix @PhoebeHui