Adds vcpkg item to project settings in Visual Studio

[Neumann-A]

To solve #4359

Problem currently:
<PropertyPageSchema Include="C:\Sources\Extern\vcpkg\scripts\buildsystems\msbuild\vcpkg-general.xml">
is an absolute path (replacing with ([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), .vcpkg-root))\scripts\buildsystems\msbuild\vcpkg-general.xml did not work)

and

Property $(VcpkgRoot) is currently blank

edit: All fields are blank; I just had a *.props file added to my project to define some of the values. So we need to included those into vcpkg.system.props to define defaults.

To solve this: Changes in commands.integrate.cpp may be necessary?

[Neumann-A]

Another nice feature would be to scan the triplet folder on integration and make the VcpkgTriplet selection an enum based on that.

Example how to do enums in the xml are given in C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\VC\VCTargets\1033\cl.xml or whereever your Visual Studio installation lies

[Neumann-A]

All issues resolved? At least seems to work now. Are there more settings which should be added?

[yuehuang010]

Overall, looks good. Please address the space/tabs to be consistant with the rest of the documents.
The $(Platform) is almost always defined and is (almost) never empty.

I only review the goal and changes to achieve the goal. I don't validate correctness and testing. Please make sure that each field in the property page works as indented.

[Neumann-A]

Does this work with older Visual Studio versions? Only checked for latest version of Visual Studio 2017. If it does not generally work I can change it back to the old conditional.

[ras0219-msft]

Thanks for the PR! This is really cool!

Testing to be done before this can be merged:

• vcpkg integrate project (with and without vcpkg integrate install on another repo)
• vcpkg export --nuget (with and without vcpkg integrate install)
• Multiple packages from vcpkg export --nuget (should either choose one or fail understandably)

Additionally, this will break all current users who have run integrate install when they git pull. Could the .props file be pulled in at the top of the .targets instead, so the appdata shortcut would not need to be modified?

[Neumann-A]

Additionally, this will break all current users who have run integrate install when they git pull. Could the .props file be pulled in at the top of the .targets instead, so the appdata shortcut would not need to be modified?

Tried that first. The fields in the property page are empty then. The defaults can only be set in a *.props file. I also tried to import a *.props file in the available applocal *.target file but this also does not work. Since bootstrap must be run anyway to recompile vcpkg you could make a call to vcpkg integrate install mandatory if system wide user integration is detected after recompiling.

[Neumann-A]

Note for people who want to play with this and change settings/properties/layout:
If you want to change anything in the vcpkg.props, vcpkg.targets or vcpkg-general.xml close Visual Studio completly after or before the changes and then reload your project. Just closing the project seems to be not enough. VS somehow remembers/caches the previous files without reloading them....(at least I was wondering more than once why my changes would not become visible or do anything.)

[yuehuang010]

Yes, VS caches all .targets, .props, and property page xml. This is huge perf gain when loading multiple projects.
FYI, Build will always read from disk because it spawns msbuild out of proc.

[PhoebeHui]

@Neumann-A, thanks for contributing to vcpkg! All triplets build successfully.

[Neumann-A]

@BillyONeal: looks ok. I hope you tested it?

[BillyONeal]

@BillyONeal: looks ok. I hope you tested it?

I tested that vcpkg itself works and that our ports that rely on the msbuild integration to find dependencies work. I did not test the VS interaction here because I don't really understand that. (I just didn't want you to have to do work to merge this since it's been here a long time :) )

[BillyONeal]

Remaining todos:

• Test vcpkg integrate project without vcpkg integrate install on another repo @ras0219
• Test vcpkg integrate project with vcpkg integrate install on another repo @ras0219
• Test vcpkg export --nuget with vcpkg integrate install @ras0219
• Test vcpkg export --nuget without vcpkg integrate install @ras0219
• Test multiple packages from vcpkg export --nuget (should either choose one or fail understandably) @ras0219
• Test that this doesn't break users who used vcpkg integrate install on git pull or fix the changes such that this works. @BillyONeal

[BillyONeal]

@Neumann-A Thanks very much for your contribution!

[BillyONeal]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[aggieNick02]

This PR ends up breaking vcpkg clients who used VcpkgTriplet in .vcxproj files to specify the desired triplet. See #12062

[BillyONeal]

@strega-nil How close is your manifests PR to merging? I didn't want to address @aggieNick02 's point above yet because a fix here is going to cause another merge mess for you but if you expect that needs more than ~a day further I need to do that....

[strega-nil]

It's this friday close. Fix it and I'll merge mine back in.