[pcl] Update to 1.10.0 #10042

JackBoosY · 2020-02-13T00:52:07Z

This PR changes:

use offical changes to fix compile options (#3604).
drop cuda support with x86 arch.
drop tools support with static build.

Related: #9986

Note: All features passed in the following triplets test:

x86-windows
x64-windows
x64-windows-static: skip due to unsupported dependency vtk

Neumann-A · 2020-02-13T01:00:05Z

ports/pcl/use_flann_targets.patch

-list(APPEND PCL_LIBRARIES ${BOOST_LIBRARIES} ${QHULL_LIBRARIES} ${OPENNI_LIBRARIES} ${OPENNI2_LIBRARIES} ${ENSENSO_LIBRARIES} ${davidSDK_LIBRARIES} ${DSSDK_LIBRARIES} ${RSSDK_LIBRARIES} ${FLANN_LIBRARIES} ${VTK_LIBRARIES})
-+list(APPEND PCL_LIBRARIES ${BOOST_LIBRARIES} ${QHULL_LIBRARIES} ${OPENNI_LIBRARIES} ${OPENNI2_LIBRARIES} ${ENSENSO_LIBRARIES} ${davidSDK_LIBRARIES} ${DSSDK_LIBRARIES} ${RSSDK_LIBRARIES} flann::flann_cpp ${VTK_LIBRARIES})
+ list(APPEND PCL_LIBRARIES ${BOOST_LIBRARIES} ${QHULL_LIBRARIES} ${OPENNI_LIBRARIES} ${OPENNI2_LIBRARIES} ${ENSENSO_LIBRARIES} ${davidSDK_LIBRARIES} ${DSSDK_LIBRARIES} ${RSSDK_LIBRARIES} ${RSSDK2_LIBRARIES} ${VTK_LIBRARIES})
+-if (TARGET FLANN::FLANN)


Instead of patching all the FLANN::FLANN targets away. Do the following:

do not remove FindFLANN.cmake

make/patch FindFLANN to find the flann configs

reroute the targets defined by the flann config (e.g. flann::flann_cpp) to be FLANN::FLANN via add_library(FLANN::FLANN ALIAS flann::flann_cpp)
doing it that way requires less patches

JackBoosY · 2020-02-13T01:11:02Z

@Neumann-A When I try to build install pcl[qt,pcap,cuda,opengl]:x64-windows-static :

Please define _WIN32_WINNT or _WIN32_WINDOWS appropriately. For example:
- add -D_WIN32_WINNT=0x0601 to the compiler command line; or
- add _WIN32_WINNT=0x0601 to your project's Preprocessor Definitions.
Assuming _WIN32_WINNT=0x0601 (i.e. Windows 7 target).
[63/512] C:\PROGRA~2\MICROS~1\2017\PROFES~1\VC\Tools\MSVC\1416~1.270\bin\Hostx64\x64\cl.exe   /TP -DBOOST_LIB_DIAGNOSTIC -DHAVE_PCAP -DPCL_BUILT_WITH_VTK -DvtkRenderingContext2D_AUTOINIT=1(vtkRenderingContextOpenGL2) -DvtkRenderingCore_AUTOINIT=3(vtkInteractionStyle,vtkRenderingFreeType,vtkRenderingOpenGL2) -IF:\vcpkg\installed\x64-windows-static\share\vtk\..\..\include -IF:\vcpkg\installed\x64-windows-static\share\vtk\..\..\include\eigen3 -IF:\vcpkg\installed\x64-windows-static\share\vtk\..\..\include\double-conversion -Iinclude -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\common\include -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\octree\include -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\openni\include -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\openni2\include -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\ensenso\include -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\davidSDK\include -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\dssdk\include -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\rssdk\include -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\rssdk2\include -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\pcap\include -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\png\include -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\vtk\include -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\io\include -IF:\vcpkg\installed\x64-windows-static\include\eigen3 -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\recognition\include\pcl\recognition\3rdparty -IF:\vcpkg\installed\x64-windows-static\include /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  /FS -openmp  /D_DEBUG /MTd /Z7 /Ob0 /Od /RTC1    -DBOOST_ALL_NO_LIB -D_SCL_SECURE_NO_WARNINGS -D_CRT_SECURE_NO_WARNINGS -DNOMINMAX -DPCL_ONLY_CORE_POINT_TYPES  /bigobj -std:c++14 /showIncludes /Foio\CMakeFiles\pcl_io.dir\src\hdl_grabber.cpp.obj /Fdio\CMakeFiles\pcl_io.dir\pcl_io.pdb /FS -c F:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\io\src\hdl_grabber.cpp
FAILED: io/CMakeFiles/pcl_io.dir/src/hdl_grabber.cpp.obj 
C:\PROGRA~2\MICROS~1\2017\PROFES~1\VC\Tools\MSVC\1416~1.270\bin\Hostx64\x64\cl.exe   /TP -DBOOST_LIB_DIAGNOSTIC -DHAVE_PCAP -DPCL_BUILT_WITH_VTK -DvtkRenderingContext2D_AUTOINIT=1(vtkRenderingContextOpenGL2) -DvtkRenderingCore_AUTOINIT=3(vtkInteractionStyle,vtkRenderingFreeType,vtkRenderingOpenGL2) -IF:\vcpkg\installed\x64-windows-static\share\vtk\..\..\include -IF:\vcpkg\installed\x64-windows-static\share\vtk\..\..\include\eigen3 -IF:\vcpkg\installed\x64-windows-static\share\vtk\..\..\include\double-conversion -Iinclude -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\common\include -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\octree\include -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\openni\include -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\openni2\include -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\ensenso\include -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\davidSDK\include -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\dssdk\include -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\rssdk\include -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\rssdk2\include -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\pcap\include -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\png\include -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\vtk\include -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\io\include -IF:\vcpkg\installed\x64-windows-static\include\eigen3 -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\recognition\include\pcl\recognition\3rdparty -IF:\vcpkg\installed\x64-windows-static\include /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  /FS -openmp  /D_DEBUG /MTd /Z7 /Ob0 /Od /RTC1    -DBOOST_ALL_NO_LIB -D_SCL_SECURE_NO_WARNINGS -D_CRT_SECURE_NO_WARNINGS -DNOMINMAX -DPCL_ONLY_CORE_POINT_TYPES  /bigobj -std:c++14 /showIncludes /Foio\CMakeFiles\pcl_io.dir\src\hdl_grabber.cpp.obj /Fdio\CMakeFiles\pcl_io.dir\pcl_io.pdb /FS -c F:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\io\src\hdl_grabber.cpp
Microsoft (R) C/C++ Optimizing Compiler Version 19.16.27034 for x64
Copyright (C) Microsoft Corporation.  All rights reserved.

Please define _WIN32_WINNT or _WIN32_WINDOWS appropriately. For example:
- add -D_WIN32_WINNT=0x0601 to the compiler command line; or
- add _WIN32_WINNT=0x0601 to your project's Preprocessor Definitions.
Assuming _WIN32_WINNT=0x0601 (i.e. Windows 7 target).
F:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\io\src\hdl_grabber.cpp(510): warning C4101: 'bind': unreferenced local variable
f:\vcpkg\installed\x64-windows-static\include\boost\variant\detail\forced_return.hpp(43) : error C4716: 'boost::detail::variant::forced_return<boost::variant<boost::shared_ptr<void>,boost::signals2::detail::foreign_void_shared_ptr> >': must return a value
f:\vcpkg\installed\x64-windows-static\include\boost\variant\detail\forced_return.hpp(43) : error C4716: 'boost::detail::variant::forced_return<bool>': must return a value
[64/512] C:\PROGRA~2\MICROS~1\2017\PROFES~1\VC\Tools\MSVC\1416~1.270\bin\Hostx64\x64\cl.exe   /TP -DBOOST_LIB_DIAGNOSTIC -DvtkRenderingContext2D_AUTOINIT=1(vtkRenderingContextOpenGL2) -DvtkRenderingCore_AUTOINIT=3(vtkInteractionStyle,vtkRenderingFreeType,vtkRenderingOpenGL2) -IF:\vcpkg\installed\x64-windows-static\share\vtk\..\..\include -IF:\vcpkg\installed\x64-windows-static\share\vtk\..\..\include\eigen3 -IF:\vcpkg\installed\x64-windows-static\share\vtk\..\..\include\double-conversion -Iinclude -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\common\include -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\search\include -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\kdtree\include -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\octree\include -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\filters\include -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\2d\include -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\features\include -IF:\vcpkg\installed\x64-windows-static\include\eigen3 -IF:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\recognition\include\pcl\recognition\3rdparty -IF:\vcpkg\installed\x64-windows-static\include /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  /FS -openmp  /D_DEBUG /MTd /Z7 /Ob0 /Od /RTC1    -DBOOST_ALL_NO_LIB -D_SCL_SECURE_NO_WARNINGS -D_CRT_SECURE_NO_WARNINGS -DNOMINMAX -DPCL_ONLY_CORE_POINT_TYPES  /bigobj -std:c++14 /showIncludes /Fofeatures\CMakeFiles\pcl_features.dir\src\flare.cpp.obj /Fdfeatures\CMakeFiles\pcl_features.dir\pcl_features.pdb /FS -c F:\vcpkg\buildtrees\pcl\src\c587a5bbcd-ba5710e4c5\features\src\flare.cpp
Microsoft (R) C/C++ Optimizing Compiler Version 19.16.27034 for x64
Copyright (C) Microsoft Corporation.  All rights reserved.

Any ideas?

And I found that PCLAPI_EXPORTS is always defined in windows, whether building dynamic or static libraries.

NancyLi1013 · 2020-02-13T02:44:57Z

Related issue #9765

Neumann-A · 2020-02-13T08:51:35Z

@Neumann-A No idea. Did not encounter that issue

JackBoosY · 2020-02-20T02:27:29Z

/azp run

PhoebeHui · 2020-05-14T02:42:50Z

@JackBoosY, could you reoslve conficts?

jasjuang · 2020-07-03T05:22:19Z

Can we get a pcl 1.11.0 update? Boost is very up to date on vcpkg but it breaks the old 1.9.1 pcl. There are a lot of boost related fixes upstream in the newer version of pcls.

Neumann-A · 2020-07-03T06:41:26Z

Probably should also add PointCloudLibrary/pcl#4096 as a patch so people don't complain about visualization missing

…jack/update_pcl_1.10.0

JackBoosY · 2020-07-03T07:04:50Z

@Neumann-A There are too many changes, I think we should wait to merge them into pcl master.

JackBoosY · 2020-07-06T06:11:44Z

Should wait for #12279 merge.

JackBoosY · 2020-07-16T01:52:47Z

/azp run

azure-pipelines · 2020-07-16T01:52:55Z

Azure Pipelines successfully started running 1 pipeline(s).

bpoebiapl · 2020-07-30T03:31:03Z

any update?

JackBoosY · 2020-07-30T03:50:33Z

@bpoebiapl Once all test passed, this PR will be merged.

BillyONeal · 2020-08-18T22:20:32Z

Thanks for your contribution!

bpoebiapl · 2020-08-22T05:25:06Z

thanks!

JackBoosY added 2 commits February 12, 2020 16:48

[pcl] Update to 1.10.0

37e72c4

[pcl] Remove useless patch

83aff2e

JackBoosY added the info:internal This PR or Issue was filed by the vcpkg team. label Feb 13, 2020

JackBoosY assigned PhoebeHui Feb 13, 2020

JackBoosY changed the title ~~Dev/jack/update pcl 1.10.0~~ [pcl] Update to 1.10.0 Feb 13, 2020

[pcl] Fix some compile options

28442d3

Neumann-A reviewed Feb 13, 2020

View reviewed changes

PhoebeHui added the wip label Feb 13, 2020

JackBoosY mentioned this pull request Feb 13, 2020

Fix baseline error #10051

Merged

JackBoosY marked this pull request as ready for review February 20, 2020 13:42

Merge branch 'master' into dev/jack/update_pcl_1.10.0

e568adc

strega-nil marked this pull request as draft May 21, 2020 21:51

strega-nil removed the legacy:wip label May 21, 2020

JackBoosY added the category:port-update The issue is with a library, which is requesting update new revision label May 22, 2020

PhoebeHui added the requires:author-response label Jul 1, 2020

JackBoosY added 2 commits July 2, 2020 23:47

Merge branch 'master' of https://github.com/microsoft/vcpkg into dev/…

760cb14

…jack/update_pcl_1.10.0

[pcl] Update to 1.11.0 and remove unnecessary patches.

f168a6a

[pcl] Add dependency boost-sort and re-fix the compile flag

a84af84

JackBoosY added depends:different-pr This PR or Issue depends on a PR which has been filed and removed requires:author-response labels Jul 3, 2020

JackBoosY removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Jul 7, 2020

JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Jul 7, 2020

[pcl] Remove broken executable targets.

338b97a

JackBoosY marked this pull request as ready for review July 7, 2020 06:21

JackBoosY removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Jul 16, 2020

NancyLi1013 mentioned this pull request Aug 13, 2020

[pcl] update to 1.10 #9765

Closed

BillyONeal merged commit b54f17e into microsoft:master Aug 18, 2020

JackBoosY deleted the dev/jack/update_pcl_1.10.0 branch August 19, 2020 02:09

remz1337 pushed a commit to remz1337/vcpkg that referenced this pull request Aug 23, 2020

[pcl] Update to 1.10.0 (microsoft#10042)

06baf43

mvieth mentioned this pull request Jan 12, 2023

[pcl] update to version 1.13.0 #28818

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pcl] Update to 1.10.0 #10042

[pcl] Update to 1.10.0 #10042

JackBoosY commented Feb 13, 2020 •

edited

Loading

Neumann-A Feb 13, 2020

JackBoosY commented Feb 13, 2020 •

edited

Loading

NancyLi1013 commented Feb 13, 2020

Neumann-A commented Feb 13, 2020

JackBoosY commented Feb 20, 2020

PhoebeHui commented May 14, 2020

jasjuang commented Jul 3, 2020

Neumann-A commented Jul 3, 2020

JackBoosY commented Jul 3, 2020

JackBoosY commented Jul 6, 2020

JackBoosY commented Jul 16, 2020

azure-pipelines bot commented Jul 16, 2020

bpoebiapl commented Jul 30, 2020

JackBoosY commented Jul 30, 2020

BillyONeal commented Aug 18, 2020

bpoebiapl commented Aug 22, 2020

[pcl] Update to 1.10.0 #10042

[pcl] Update to 1.10.0 #10042

Conversation

JackBoosY commented Feb 13, 2020 • edited Loading

Neumann-A Feb 13, 2020

Choose a reason for hiding this comment

JackBoosY commented Feb 13, 2020 • edited Loading

NancyLi1013 commented Feb 13, 2020

Neumann-A commented Feb 13, 2020

JackBoosY commented Feb 20, 2020

PhoebeHui commented May 14, 2020

jasjuang commented Jul 3, 2020

Neumann-A commented Jul 3, 2020

JackBoosY commented Jul 3, 2020

JackBoosY commented Jul 6, 2020

JackBoosY commented Jul 16, 2020

azure-pipelines bot commented Jul 16, 2020

bpoebiapl commented Jul 30, 2020

JackBoosY commented Jul 30, 2020

BillyONeal commented Aug 18, 2020

bpoebiapl commented Aug 22, 2020

JackBoosY commented Feb 13, 2020 •

edited

Loading

JackBoosY commented Feb 13, 2020 •

edited

Loading