Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openmvs] update to v1.1 #10110

Merged
merged 2 commits into from
Feb 29, 2020
Merged

[openmvs] update to v1.1 #10110

merged 2 commits into from
Feb 29, 2020

Conversation

cdcseacave
Copy link
Contributor

No description provided.

@cdcseacave
Copy link
Contributor Author

hmmm, I'm lost, the logs say this

       "C:\vsts\_work\1\s\buildtrees\osg\x64-windows-dbg\examples\osgmovie\example_osgmovie.vcxproj" (default target) (88) ->
       (ClCompile target) -> 
         C:\vsts\_work\1\s\buildtrees\osg\src\raph-3.6.4-9780889fab\examples\osgmovie\osgmovie.cpp(694,10): error C1083:  Cannot open include file: 'SDL/SDL.h': No such file or directory [C:\vsts\_work\1\s\buildtrees\osg\x64-windows-dbg\examples\osgmovie\example_osgmovie.vcxproj]

however I compile OpenMVS which does not use or contain osg (do not even know what that is. So how come it does that and why it repots failure for my port?

PhoebeHui
PhoebeHui approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhoebeHui
Copy link
Contributor

/azp run

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Feb 20, 2020
@cdcseacave
Copy link
Contributor Author

?

PhoebeHui
PhoebeHui requested changes Feb 28, 2020
View reviewed changes
ports/openmvs/CONTROL Outdated Show resolved Hide resolved
@PhoebeHui PhoebeHui added waiting for response and removed info:reviewed Pull Request changes follow basic guidelines labels Feb 28, 2020
@PhoebeHui PhoebeHui added info:reviewed Pull Request changes follow basic guidelines and removed waiting for response labels Feb 28, 2020
@strega-nil
Copy link
Contributor

Thanks @cdcseacave :)

@strega-nil strega-nil merged commit 57c7de7 into microsoft:master Feb 29, 2020
@cdcseacave cdcseacave deleted the openmvs11 branch February 29, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdcseacave @PhoebeHui @strega-nil