Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ffmpeg] Fix build static error #10368

Merged
merged 2 commits into from
Mar 19, 2020

Conversation

NancyLi1013
Copy link
Contributor

@NancyLi1013 NancyLi1013 commented Mar 10, 2020

When building ffmpeg with ffmpeg or ffprobe in static, it will post the error:

There should be no bin\ directory in a static build, but D:\GitHub\vcpkg\packages\ffmpeg_x86-windows-static\bin is present.
There should be no debug\bin\ directory in a static build, but D:\GitHub\vcpkg\packages\ffmpeg_x86-windows-static\debug\bin is present.
If the creation of bin\ and/or debug\bin\ cannot be disabled, use this in the portfile to remove them

    if(VCPKG_LIBRARY_LINKAGE STREQUAL "static")
        file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/bin ${CURRENT_PACKAGES_DIR}/debug/bin)
    endif()

There should be no empty directories in D:\GitHub\vcpkg\packages\ffmpeg_x86-windows-static
The following empty directories were found:

    D:/GitHub/vcpkg/packages/ffmpeg_x86-windows-static/bin
    D:/GitHub/vcpkg/packages/ffmpeg_x86-windows-static/debug/bin

So I remove these folder to fix this issue.

Related issue #9949.

Note: All features have been passed with the following triplets:

@NancyLi1013 NancyLi1013 added the info:internal This PR or Issue was filed by the vcpkg team. label Mar 10, 2020
@NancyLi1013 NancyLi1013 marked this pull request as ready for review March 10, 2020 13:03
ports/ffmpeg/portfile.cmake Outdated Show resolved Hide resolved
@PhoebeHui PhoebeHui added info:reviewed Pull Request changes follow basic guidelines and removed waiting for response labels Mar 13, 2020
@dan-shaw dan-shaw merged commit 3d82def into microsoft:master Mar 19, 2020
@cenit
Copy link
Contributor

cenit commented Mar 20, 2020

wasn't it better to move them to tools, instead of removing them?

@cenit cenit mentioned this pull request Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants