Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[basisu] Remove basis universal port #10761

Closed
wants to merge 1 commit into from

Conversation

jherico
Copy link
Contributor

@jherico jherico commented Apr 9, 2020

The basis universal port relies on a fork of the upstream library that no longer exists.

  • What does your PR fix?

Build failure of basisu port

@Neumann-A
Copy link
Contributor

switch to https://github.com/BinomialLLC/basis_universal instead of deleting?

@jherico
Copy link
Contributor Author

jherico commented Apr 9, 2020

@Neumann-A the port as is depends heavily on a CMake refactor of the original repository. Simply switching over would require additional work. I have been maintaining the fork and the vcpkg port for about a year now but the cmake refactor PR against the upstream repo is no closer to being merged. If @richgel999 wants to maintain this he is free to do so.

@cenit
Copy link
Contributor

cenit commented Apr 9, 2020

as a historical note, here it is the original PR @jherico used in his fork, in case anyone wants to adopt the port.

BinomialLLC/basis_universal#13

Let me be clear: this is another reason we should not accept ports coming from forks done only to reduce patchset. We should use original repositories as much as possible, otherwise repositories can go away without any notice and only for vcpkg...

@PhoebeHui PhoebeHui changed the title Remove basis universal port [basisu] Remove basis universal port Apr 10, 2020
@PhoebeHui
Copy link
Contributor

It affects 2 features for port magnum-plugins, @jherico, could you also remove the 2 features from magnum-plugins?

They are added by PR #8742, @Squareys, let us know if you have any concern about removing the 2 featues.

Feature: basisimageconverter
Description: BasisImageConverter plugin
Build-Depends: magnum[trade], basisu

Feature: basisimporter
Description: BasisImporter plugin
Build-Depends: magnum[trade], basisu

@jherico
Copy link
Contributor Author

jherico commented Apr 10, 2020

In order to avoid inconveniencing the Magnum developers, I've restored the repository and archived it instead of deleting it.

@jherico jherico closed this Apr 10, 2020
@cenit
Copy link
Contributor

cenit commented Apr 10, 2020

@jherico thanks

@PhoebeHui in parallel, do you think it would be better to rebase the port onto the original repository + patch-set?

@mosra
Copy link

mosra commented Apr 10, 2020

@jherico oh, thanks for backtracking on this.

I'm planning to bundle Basis sources for Homebrew packages anyway, so I might do that for vcpkg as well then. It's sad to see upstream completely ignoring the proposed CMake improvements, but what can we do.

@PhoebeHui
Copy link
Contributor

@cenit, it would be better to rebase the port onto the original repository + patch-set, however, if the patches contains huge changes, it will be hard to upgarde the port, since we need regenarte the patches each time, so I think it depends on how many files and changes it has.

@jherico, thanks for restoring the repository!

@mosra, we are looking forward to your PRs for basisu port!

@mosra mosra mentioned this pull request May 29, 2020
87 tasks
@mosra
Copy link

mosra commented Jul 2, 2020

@jherico @PhoebeHui once #12211 gets merged, the basisu port can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants