-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[basisu] Remove basis universal port #10761
Conversation
switch to https://github.com/BinomialLLC/basis_universal instead of deleting? |
@Neumann-A the port as is depends heavily on a CMake refactor of the original repository. Simply switching over would require additional work. I have been maintaining the fork and the vcpkg port for about a year now but the cmake refactor PR against the upstream repo is no closer to being merged. If @richgel999 wants to maintain this he is free to do so. |
as a historical note, here it is the original PR @jherico used in his fork, in case anyone wants to adopt the port. BinomialLLC/basis_universal#13 Let me be clear: this is another reason we should not accept ports coming from forks done only to reduce patchset. We should use original repositories as much as possible, otherwise repositories can go away without any notice and only for vcpkg... |
It affects 2 features for port magnum-plugins, @jherico, could you also remove the 2 features from magnum-plugins? They are added by PR #8742, @Squareys, let us know if you have any concern about removing the 2 featues. Feature: basisimageconverter Feature: basisimporter |
In order to avoid inconveniencing the Magnum developers, I've restored the repository and archived it instead of deleting it. |
@jherico thanks @PhoebeHui in parallel, do you think it would be better to rebase the port onto the original repository + patch-set? |
@jherico oh, thanks for backtracking on this. I'm planning to bundle Basis sources for Homebrew packages anyway, so I might do that for vcpkg as well then. It's sad to see upstream completely ignoring the proposed CMake improvements, but what can we do. |
@cenit, it would be better to rebase the port onto the original repository + patch-set, however, if the patches contains huge changes, it will be hard to upgarde the port, since we need regenarte the patches each time, so I think it depends on how many files and changes it has. @jherico, thanks for restoring the repository! @mosra, we are looking forward to your PRs for basisu port! |
@jherico @PhoebeHui once #12211 gets merged, the |
The basis universal port relies on a fork of the upstream library that no longer exists.
Build failure of basisu port