Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmake] Update to 3.17.2 #10767

Merged
merged 48 commits into from
May 19, 2020
Merged

[cmake] Update to 3.17.2 #10767

merged 48 commits into from
May 19, 2020

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Apr 10, 2020 •
edited
Loading

Updated to 3.17.2 to solve the issues of decompressing the source.

Related: #10657 #10552 #10336 #6059 #10492 #5951 #9078 #8603.

curlpp regression will fix in #10535.

@JackBoosY JackBoosY added the info:internal This PR or Issue was filed by the vcpkg team. label Apr 10, 2020
@Neumann-A
Copy link
Contributor

If you update CMake could you also update ninja to 1.10 (#10369)?
This way we can finally include fortran ;)

@JackBoosY JackBoosY mentioned this pull request Apr 10, 2020
Closed
@JackBoosY
Copy link
Contributor Author

@Neumann-A I think we should put them in different PRs.

@MVoz
Copy link
Contributor

MVoz commented Apr 12, 2020

@JackBoosY
merge forcibly, error somewhere in CI

@JackBoosY
Copy link
Contributor Author

For osg:x64-osx regression and replxx regression, I cannot reproduce it on my machine.
For drlibs regression, this is because the pipeline machine cannot download the source code.

@JackBoosY JackBoosY marked this pull request as ready for review April 13, 2020 07:38
PhoebeHui
PhoebeHui approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Farwaykorse Farwaykorse mentioned this pull request Apr 16, 2020
Closed
@JackBoosY
Copy link
Contributor Author

@strega-nil Build nanodbc: x64-linux succeeded on my machine, configuration information shows:

-- nanodbc build: ODBC on Unix - unixODBC
-- ODBC compile flags: -I/usr/include -DHAVE_UNISTD_H -DHAVE_PWD_H -DHAVE_SYS_TYPES_H -DHAVE_LONG_LONG -DSIZEOF_LONG_INT=8
-- ODBC link flags:

It looks like we need to install the odbc package on the pipeline machine.

@strega-nil
Copy link
Contributor

Assigning @BillyONeal as the owner of CI

@BillyONeal
Copy link
Member

@strega-nil I don't see any CI system edits here?

@BillyONeal
Copy link
Member

Oh, I see, it's in the chat. @JackBoosY Can you add the changes necessary to do that to provision-image.ps1 ?

@MVoz
Copy link
Contributor

MVoz commented May 17, 2020

@JackBoosY
everyone waiting for you ))

@JackBoosY
Copy link
Contributor Author

JackBoosY commented May 18, 2020 •
edited
Loading

  • itk:x64-osx
[1621/1622] : && /Library/Developer/CommandLineTools/usr/bin/c++  -fPIC  -mtune=native -march=corei7 -Wall -Wcast-align -Wdisabled-optimization -Wextra -Wformat=2 -Winvalid-pch -Wno-format-nonliteral -Wpointer-arith -Wshadow -Wunused -Wwrite-strings -funit-at-a-time -Wno-strict-overflow -Wno-deprecated -Wno-invalid-offsetof -Wno-undefined-var-template -Woverloaded-virtual  -g -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -Wl,-search_paths_first -Wl,-headerpad_max_install_names -fPIE -Xlinker -pie Modules/Core/TestKernel/src/CMakeFiles/itkTestDriver.dir/itkTestDriver.cxx.o  -o bin/itkTestDriver  lib/libITKIOBMP-5.0.a  lib/libITKIOGDCM-5.0.a  lib/libITKIOGIPL-5.0.a  lib/libITKIOJPEG-5.0.a  lib/libITKIOMeshBYU-5.0.a  lib/libITKIOMeshFreeSurfer-5.0.a  lib/libITKIOMeshGifti-5.0.a  lib/libITKIOMeshOBJ-5.0.a  lib/libITKIOMeshOFF-5.0.a  lib/libITKIOMeshVTK-5.0.a  lib/libITKIOMeta-5.0.a  lib/libITKIONIFTI-5.0.a  lib/libITKIONRRD-5.0.a  lib/libITKIOPNG-5.0.a  lib/libITKIOTIFF-5.0.a  lib/libITKIOVTK-5.0.a  lib/libITKCommon-5.0.a  lib/libITKIOImageBase-5.0.a  lib/libITKTestKernel-5.0.a  lib/libITKIOBMP-5.0.a  lib/libITKIOGDCM-5.0.a  lib/libitkgdcmMSFF-5.0.a  lib/libitkgdcmDICT-5.0.a  lib/libitkgdcmIOD-5.0.a  lib/libitkgdcmDSED-5.0.a  lib/libitkgdcmCommon-5.0.a  -framework  CoreFoundation  lib/libitkgdcmjpeg8-5.0.a  lib/libitkgdcmjpeg12-5.0.a  lib/libitkgdcmjpeg16-5.0.a  /Volumes/data/work/1/s/installed/x64-osx/debug/lib/libopenjp2.a  lib/libitkgdcmcharls-5.0.a  lib/libitkgdcmuuid-5.0.a  lib/libITKIOGIPL-5.0.a  lib/libITKIOJPEG-5.0.a  lib/libITKIOMeshBYU-5.0.a  lib/libITKIOMeshFreeSurfer-5.0.a  lib/libITKIOMeshGifti-5.0.a  lib/libITKgiftiio-5.0.a  /Volumes/data/work/1/s/installed/x64-osx/debug/lib/libexpat.a  lib/libITKIOMeshOBJ-5.0.a  lib/libITKIOMeshOFF-5.0.a  lib/libITKIOMeshVTK-5.0.a  lib/libITKIOMeshBase-5.0.a  lib/libITKQuadEdgeMesh-5.0.a  lib/libITKMesh-5.0.a  lib/libITKIOMeta-5.0.a  lib/libITKMetaIO-5.0.a  lib/libITKIONIFTI-5.0.a  lib/libITKniftiio-5.0.a  lib/libITKznz-5.0.a  lib/libITKTransform-5.0.a  lib/libITKIONRRD-5.0.a  lib/libITKNrrdIO-5.0.a  lib/libITKIOPNG-5.0.a  /Volumes/data/work/1/s/installed/x64-osx/debug/lib/libpng16d.a  lib/libITKIOTIFF-5.0.a  /Volumes/data/work/1/s/installed/x64-osx/debug/lib/libtiffd.a  /Volumes/data/work/1/s/installed/x64-osx/debug/lib/liblzmad.a  /Volumes/data/work/1/s/installed/x64-osx/debug/lib/libz.a  /Volumes/data/work/1/s/installed/x64-osx/debug/lib/libjpeg.a  lib/libITKIOVTK-5.0.a  lib/libITKIOImageBase-5.0.a  lib/libITKCommon-5.0.a  /Volumes/data/work/1/s/installed/x64-osx/debug/lib/libdouble-conversion.a  lib/libitksys-5.0.a  lib/libITKVNLInstantiation-5.0.a  lib/libitkvnl_algo-5.0.a  lib/libitkvnl-5.0.a  lib/libitkv3p_netlib-5.0.a  lib/libitknetlib-5.0.a  lib/libitkvcl-5.0.a  -lm  -lm && :
FAILED: bin/itkTestDriver 
: && /Library/Developer/CommandLineTools/usr/bin/c++  -fPIC  -mtune=native -march=corei7 -Wall -Wcast-align -Wdisabled-optimization -Wextra -Wformat=2 -Winvalid-pch -Wno-format-nonliteral -Wpointer-arith -Wshadow -Wunused -Wwrite-strings -funit-at-a-time -Wno-strict-overflow -Wno-deprecated -Wno-invalid-offsetof -Wno-undefined-var-template -Woverloaded-virtual  -g -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -Wl,-search_paths_first -Wl,-headerpad_max_install_names -fPIE -Xlinker -pie Modules/Core/TestKernel/src/CMakeFiles/itkTestDriver.dir/itkTestDriver.cxx.o  -o bin/itkTestDriver  lib/libITKIOBMP-5.0.a  lib/libITKIOGDCM-5.0.a  lib/libITKIOGIPL-5.0.a  lib/libITKIOJPEG-5.0.a  lib/libITKIOMeshBYU-5.0.a  lib/libITKIOMeshFreeSurfer-5.0.a  lib/libITKIOMeshGifti-5.0.a  lib/libITKIOMeshOBJ-5.0.a  lib/libITKIOMeshOFF-5.0.a  lib/libITKIOMeshVTK-5.0.a  lib/libITKIOMeta-5.0.a  lib/libITKIONIFTI-5.0.a  lib/libITKIONRRD-5.0.a  lib/libITKIOPNG-5.0.a  lib/libITKIOTIFF-5.0.a  lib/libITKIOVTK-5.0.a  lib/libITKCommon-5.0.a  lib/libITKIOImageBase-5.0.a  lib/libITKTestKernel-5.0.a  lib/libITKIOBMP-5.0.a  lib/libITKIOGDCM-5.0.a  lib/libitkgdcmMSFF-5.0.a  lib/libitkgdcmDICT-5.0.a  lib/libitkgdcmIOD-5.0.a  lib/libitkgdcmDSED-5.0.a  lib/libitkgdcmCommon-5.0.a  -framework  CoreFoundation  lib/libitkgdcmjpeg8-5.0.a  lib/libitkgdcmjpeg12-5.0.a  lib/libitkgdcmjpeg16-5.0.a  /Volumes/data/work/1/s/installed/x64-osx/debug/lib/libopenjp2.a  lib/libitkgdcmcharls-5.0.a  lib/libitkgdcmuuid-5.0.a  lib/libITKIOGIPL-5.0.a  lib/libITKIOJPEG-5.0.a  lib/libITKIOMeshBYU-5.0.a  lib/libITKIOMeshFreeSurfer-5.0.a  lib/libITKIOMeshGifti-5.0.a  lib/libITKgiftiio-5.0.a  /Volumes/data/work/1/s/installed/x64-osx/debug/lib/libexpat.a  lib/libITKIOMeshOBJ-5.0.a  lib/libITKIOMeshOFF-5.0.a  lib/libITKIOMeshVTK-5.0.a  lib/libITKIOMeshBase-5.0.a  lib/libITKQuadEdgeMesh-5.0.a  lib/libITKMesh-5.0.a  lib/libITKIOMeta-5.0.a  lib/libITKMetaIO-5.0.a  lib/libITKIONIFTI-5.0.a  lib/libITKniftiio-5.0.a  lib/libITKznz-5.0.a  lib/libITKTransform-5.0.a  lib/libITKIONRRD-5.0.a  lib/libITKNrrdIO-5.0.a  lib/libITKIOPNG-5.0.a  /Volumes/data/work/1/s/installed/x64-osx/debug/lib/libpng16d.a  lib/libITKIOTIFF-5.0.a  /Volumes/data/work/1/s/installed/x64-osx/debug/lib/libtiffd.a  /Volumes/data/work/1/s/installed/x64-osx/debug/lib/liblzmad.a  /Volumes/data/work/1/s/installed/x64-osx/debug/lib/libz.a  /Volumes/data/work/1/s/installed/x64-osx/debug/lib/libjpeg.a  lib/libITKIOVTK-5.0.a  lib/libITKIOImageBase-5.0.a  lib/libITKCommon-5.0.a  /Volumes/data/work/1/s/installed/x64-osx/debug/lib/libdouble-conversion.a  lib/libitksys-5.0.a  lib/libITKVNLInstantiation-5.0.a  lib/libitkvnl_algo-5.0.a  lib/libitkvnl-5.0.a  lib/libitkv3p_netlib-5.0.a  lib/libitknetlib-5.0.a  lib/libitkvcl-5.0.a  -lm  -lm && :
Undefined symbols for architecture x86_64:
  "gdcm::Rescaler::SetMinMaxForPixelType(double, double)", referenced from:
      itk::GDCMImageIO::Write(void const*) in libITKIOGDCM-5.0.a(itkGDCMImageIO.cxx.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.
  • osg:x64-linux
/mnt/_work/1/s/buildtrees/osg/src/raph-3.6.4-c5448290ed/src/osgPlugins/RestHttpDevice/connection.cpp:43:29: error: ‘error’ is not a member of ‘asio::placeholders’
         asio::placeholders::error,
                             ^~~~~

@JackBoosY
Copy link
Contributor Author

Temporarily disable itk:x64-osx, osg:x64-linux, nanodbc:x64-linux in hope of merging the PR as soon as possible.

@strega-nil @BillyONeal

@JackBoosY JackBoosY removed the wip label May 18, 2020
@MVoz
Copy link
Contributor

MVoz commented May 18, 2020

@JackBoosY
transfer the code to yourself, or the merge will be delayed for another 100 years

https://github.com/microsoft/vcpkg/pull/11414/files
provision-image.ps1

@BillyONeal BillyONeal added the depends:vm-update PR contains changes to the VM provisioning scripts label May 19, 2020
@BillyONeal BillyONeal merged commit f23ebed into microsoft:master May 19, 2020
@JackBoosY JackBoosY deleted the dev/jack/update_cmake_3.17.1 branch May 20, 2020 02:08
@BillyONeal BillyONeal mentioned this pull request May 20, 2020
Closed
@JackBoosY JackBoosY mentioned this pull request May 27, 2020
Merged
@moetayuko moetayuko mentioned this pull request Jun 4, 2020
Closed
@BillyONeal BillyONeal removed the depends:vm-update PR contains changes to the VM provisioning scripts label Jun 11, 2020
@NancyLi1013 NancyLi1013 mentioned this pull request Jul 31, 2020
Merged
strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
@JackBoosY
[cmake] Update to 3.17.2 (microsoft#10767)
64a55c4 
* [cmake] Update to 3.17.1

* update cmake directory name

* [cpuid] Fix install headers.

* [stormlib] Fix install headers

* [murmurhash] Fix install headers

* [metrohash] Fix install headers

* update baseline

* update baseline

* [otl] update hash

* update baseline

* [gts] Do not use ninja to avoid empty implib issue

* update baseline

* [dmlc] Re-trigger ci test

* [replxx] Re-trigger ci test

* update baseline

* [osg] Re-trigger ci test

* [replxx] Fix build failure

* Set cmake min version to 3.17.1

* update baseline

* [libnice] Re-trigger ci test

* [mlpack] Re-trigger ci test

* update to 3.17.2

* update cmake hash

* update baseline

* update baseline

* update baseline

* update baseline

* Update scripts/ci.baseline.txt

Co-authored-by: Billy O'Neal <billy.oneal@gmail.com>

* update baseline

* update baseline

* [magnum] Set magnum:arm64-windows to skip in baseline

* [nanogui] Set nanogui:arm64-windows to fail in baseline

* [nettle] Set nettle:x64-windows to fail, waiting for fix this issue in another PR

* re-trigger CI test

* update baseline

* Install unixODBC in Linux

* [nanodbc] Re-trigger CI test

* update baseline

* Remove space

* update baseline
@shenkonghui shenkonghui mentioned this pull request Sep 19, 2022
Closed
@JonLiu1993 JonLiu1993 mentioned this pull request Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal left review comments

@PhoebeHui PhoebeHui PhoebeHui approved these changes

@cbezault cbezault cbezault approved these changes

Assignees

@BillyONeal BillyONeal

@PhoebeHui PhoebeHui

Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JackBoosY @Neumann-A @MVoz @strega-nil @BillyONeal @cbezault @PhoebeHui