Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmake] Add cmake port to test qt #10770

Merged
merged 6 commits into from
Jul 31, 2020
Merged

[cmake] Add cmake port to test qt #10770

merged 6 commits into from
Jul 31, 2020

Conversation

Neumann-A
Copy link
Contributor

@Neumann-A Neumann-A commented Apr 10, 2020 •
edited
Loading

PR #10769 is included for static builds to work

cmake-gui in static builds will only work with Qt > 5.14 due to the automatic plugin linkage added to Qt 5.14. Seems like cmake forgot to link against and add sources to include the required qt plugins.

  • waiting for the qt 5.15 merge so i don't have to deal with the plugins in static builds ;)
  • retesting and updating

@Neumann-A
Copy link
Contributor Author

also requires at least #10644 to make static builds work

This was referenced Apr 24, 2020
Closed
Closed
Merged
@NancyLi1013 NancyLi1013 mentioned this pull request Apr 28, 2020
Closed
@Neumann-A Neumann-A mentioned this pull request Apr 28, 2020
Merged
@JackBoosY
Copy link
Contributor

Pinging @Neumann-A for response. Is work still being done for this PR?

@Neumann-A
Copy link
Contributor Author

need #11072 merged for this

cenit
cenit reviewed May 18, 2020
View reviewed changes
ports/cmake/portfile.cmake Outdated Show resolved Hide resolved
@JackBoosY JackBoosY added category:new-port The issue is requesting a new library to be added; consider making a PR! depends:different-pr This PR or Issue depends on a PR which has been filed labels Jun 11, 2020
@Neumann-A
Copy link
Contributor Author

@JackBoosY: Ready but the cmake-gui will probably not work on linux (Ubuntu 20.04) due to requiring a correct fontconfig setup or an update for it within vcpkg

@Neumann-A Neumann-A marked this pull request as ready for review July 9, 2020 15:16
@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines requires:discussion and removed depends:different-pr This PR or Issue depends on a PR which has been filed labels Jul 10, 2020
@Neumann-A Neumann-A mentioned this pull request Jul 11, 2020
Merged
8 tasks
@ras0219-msft
Copy link
Contributor

ras0219-msft commented Jul 17, 2020 •
edited
Loading

After some discussion within the team, here's our current thinking:

  1. Vcpkg is still focused on delivering libraries for developers, not general-purpose application distribution.
  2. However, this port is useful to test Qt

Therefore, we think the best path is to move this into a secondary location (scripts/test_ports/cmake) which can be passed during CI as --overlay-ports=scripts/test_ports. This enables the testing coverage granted by building cmake, but avoids introducing false expectations for users that they should vcpkg install cmake and expect to run the gui+etc out of the installed tree. Specific individuals working on Qt (like yourself) can also pass this flag locally to make the port available for testing purposes.

I'm happy to help modify the azure-pipelines.yml files to pass this additional flag once the port has been moved.

@JackBoosY JackBoosY added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines requires:discussion labels Jul 17, 2020
@Neumann-A
Copy link
Contributor Author

Would be nice if VCPKG would store overlay locations of installed ports and only error if the location does not exist any more. Otherwise I always need to pass --overlay-ports=scripts/test_ports if one if the ports from there is installed.

@JackBoosY JackBoosY added category:infrastructure Pertaining to the CI/Testing infrastrucutre info:reviewed Pull Request changes follow basic guidelines labels Jul 23, 2020
@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil strega-nil merged commit 5c66f72 into microsoft:master Jul 31, 2020
hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
@Neumann-A @hellozee
[cmake] Add cmake port to test qt (microsoft#10770)
e79e557 
* [cmake] add port for qt testing

* only add cmcldeps on windows

* [cmake] cleanup and fix portfile for osx build

* [cmake] more cleanup

* move cmake to scripts/test_ports

* add the overlay scripts/test_ports to ci
@Neumann-A Neumann-A deleted the add_cmake_for_qt_testing branch November 18, 2020 20:26
@Thieum Thieum mentioned this pull request Mar 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cenit cenit cenit left review comments

@JackBoosY JackBoosY JackBoosY approved these changes

@ras0219-msft ras0219-msft Awaiting requested review from ras0219-msft

Assignees

@JackBoosY JackBoosY

Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Neumann-A @JackBoosY @ras0219-msft @strega-nil @cenit