Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qt5-webengine] Add dep atlmfc to CONTROL. Fix patches for latest. Add some options on linux #11120

Merged
merged 2 commits into from
May 8, 2020
Merged

[qt5-webengine] Add dep atlmfc to CONTROL. Fix patches for latest. Add some options on linux #11120

merged 2 commits into from
May 8, 2020

Conversation

Neumann-A
Copy link
Contributor

closes #11100

@Neumann-A Neumann-A changed the title [qt5-webengine] Add dep to atlmfc. Fix patches for latest. Add some options on linux [qt5-webengine] Add dep atlmfc to CONTROL. Fix patches for latest. Add some options on linux May 1, 2020
@LilyWangL LilyWangL requested a review from JackBoosY May 6, 2020 01:56
@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY JackBoosY mentioned this pull request May 6, 2020
Merged
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label May 6, 2020
@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor

Ignore that x64-linux error, it is outdated.

@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY JackBoosY mentioned this pull request May 8, 2020
Merged
@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil
Copy link
Contributor

LGTM! Thanks @Neumann-A :)

@strega-nil strega-nil merged commit 62d5125 into microsoft:master May 8, 2020
@Neumann-A Neumann-A deleted the fix_qt5_latest_webengine_patches branch May 8, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[qt5-webengine] assert vc_lib_atlmfc_path AssertionError
4 participants
@Neumann-A @JackBoosY @BillyONeal @strega-nil