Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ITK] Update to 5.1 #11208

Merged
merged 85 commits into from
Aug 2, 2020
Merged

[ITK] Update to 5.1 #11208

merged 85 commits into from
Aug 2, 2020

Conversation

Neumann-A
Copy link
Contributor

@Neumann-A Neumann-A commented May 6, 2020

closes #11136
includes #11148 for feature testing

Features not tests: tbb, cufftw(due to a compile error, requires upstream fix)

@LilyWangL LilyWangL self-requested a review May 7, 2020 02:16
@JackBoosY
Copy link
Contributor

JackBoosY commented Jul 15, 2020

D:/installed/x86-windows/tools/qt5/debug/mkspecs/features/qt_plugin.prf:59: Cannot write file D:\buildtrees\qt5-imageformats\x86-windows-dbg\mkspecs\modules-inst\qt_plugin_qwbmp.pri: Cannot create parent directory
jom: D:\buildtrees\qt5-imageformats\x86-windows-dbg\src\plugins\imageformats\Makefile [sub-wbmp-make_first] Error 3
jom: D:\buildtrees\qt5-imageformats\x86-windows-dbg\src\plugins\Makefile [sub-imageformats-make_first] Error 2
jom: D:\buildtrees\qt5-imageformats\x86-windows-dbg\src\Makefile [sub-plugins-make_first] Error 2
jom: D:\buildtrees\qt5-imageformats\x86-windows-dbg\Makefile [sub-src-make_first] Error 2

It looks like it can't adapt to our pipeline environment.

@Neumann-A
Copy link
Contributor Author

It looks like it can't adapt to our pipeline environment.

I already saw that error locally so it is not the pipeline. I assume it is a parallel build or jom issue but the error is too sporadic. I never had it when I directly retried to build the port

@JackBoosY
Copy link
Contributor

@BillyONeal Could you please taka a look?

Thanks.

@BillyONeal
Copy link
Member

@BillyONeal Could you please taka a look?

I have been temporarily reassigned to STL stuff so I won't be able to soon. Also:

I already saw that error locally so it is not the pipeline. I assume it is a parallel build or jom issue but the error is too sporadic. I never had it when I directly retried to build the port

@Neumann-A
Copy link
Contributor Author

Should I clean up the commit history wit a git reset upstream/master and recommit the true changes of this PR?

@JackBoosY
Copy link
Contributor

JackBoosY commented Jul 17, 2020

@Neumann-A You don't need that, just wait for #12455 merge would be okay.

@JackBoosY JackBoosY added depends:different-pr This PR or Issue depends on a PR which has been filed requires:testing Needs tests added before merging and removed depends:different-pr This PR or Issue depends on a PR which has been filed labels Jul 20, 2020
ports/itk/wrapping.patch Outdated Show resolved Hide resolved
ports/openjpeg/CONTROL Outdated Show resolved Hide resolved
ports/opencl/CONTROL Outdated Show resolved Hide resolved
Neumann-A and others added 4 commits July 27, 2020 21:04
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
@JackBoosY JackBoosY added the category:infrastructure Pertaining to the CI/Testing infrastrucutre label Jul 30, 2020
@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil
Copy link
Contributor

pbc seems to be broken on x64-osx; it should probably be depending on gmp.

@strega-nil strega-nil merged commit 8e76503 into microsoft:master Aug 2, 2020
@Neumann-A Neumann-A deleted the update_itk_51 branch August 2, 2020 22:51
hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
* [vtk-m] new port vtk-m

* [VTK] Update to 9.0

* include local buildtree changes

* [pcl] disable VTK due to API changes in VTK 9.0

* [vtk-m] add supports field to be only x64

* [vtk-dicom] add python executable.

* fix vtkm dependency

* [vtk-dicom] fix missing std:: namespace

* [vtk-m] add uwp to unsupported triplets

* [vtk] add pegtl include patch, reenable IOMotionFX

* remove hdf5 changes for testing

* use different pgetl patch which redirects to the installed config of pegtl

* [pegtl-2] version file needs renaming too

* [vtk] change dependency to pgetl-2 and fix the patch

* [vtk] put in hdf5 fix again and correct manually installed include files

* remove deprecated function to retrigger CI

* [lz4] correctly lowercase the lz4 config

* [vtk] remove unnecessary code

* [pegtl-2] add homepage

* [pegtl] modernize portfiles

* [vtk-dicom] add homepage

* [vtk-dicom] modernize portfile

* [vtk-m] remove empty build depends

* [vtk] try fixing the permission issue

* [vtk] minimal dependency correction

* [itk] update

* fix portfile errors

* WIP commit

* should make ITK green in VCPKG CI but there a still issues with features

* more dependencies and features....

* remove itk from baseline failure so the check can get green

* more dependency updating.

* minor build fixes

* [openjpeg] Fix dll location

* fix other issues

* add rtkcuda

* [openjpeg] remove default features to make arm and uwp platforms happy

* [itk] more dependency fixes

* [openjpeg] fix no tools case

* [itk] fix wip patch

* [itk] split up patches & cleanup & and move rtk tools if build

* [itk] fix patch and remove old and wip patch

* [nifticlib] Add new port required by minc

* [nifticlib] change repo and add features

* [nifticilib] add zlib dependency & cleanup

* [minc] add new port

* [vcpkg/scripts] add swig to find acquire programm

* [itk/minc] update for external minc

* add supports field for nifticlib

* [itk] make python a default feature for testing

* [itk] cleanup python vars a bit
[vcpkg/scripts] correct swig hash

* [vcpkg/scripts] fix swig

* [itk] fix python include path on unix system

* [itk] remove python as a default. A bit of feature cleanup

* [itk] update remote RTK

* [itk|rtk] remove RTK module before configure to allow patching

* [opencl] update opencl wrapper

* [itk] fix opencl static linkage

* [itk] add cufftw fix

* update baseline

* [itk] fix itk[tbb]

* [itk] update python paths to 3.8

* [itk] add failure messages for unsupported architectures for some features

* [vcpkg_find_acquire_program] update swig to 4.0.2

* Update portfile.cmake

* [itk] move the module removal out of the if for people reusing the old source tree

* [itk] add missing auto_clean to vcpkg_copy_tools

* Update ports/nifticlib/CONTROL

Co-authored-by: Robert Schumacher <roschuma@microsoft.com>

* Update ports/openjpeg/portfile.cmake

Co-authored-by: Robert Schumacher <roschuma@microsoft.com>

* Update scripts/cmake/vcpkg_find_acquire_program.cmake

Co-authored-by: Robert Schumacher <roschuma@microsoft.com>

* [openjpeg] pass OPTIONS to vcpkg_configure_cmake

* [itk] fix typo and leave a todo.

* use sourceforge args for swig

* Update ports/openjpeg/CONTROL

Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>

* Update ports/opencl/CONTROL

Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>

* [itk] remove debug msgs from patch

* pre-install yasm on OSX

Co-authored-by: Lily <47812810+LilyWangL@users.noreply.github.com>
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
Co-authored-by: JackBoosY <yuzaiyang@beyondsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre category:port-update The issue is with a library, which is requesting update new revision requires:testing Needs tests added before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ITK] Spurious build failure on osx-x64 [itk] update to 5.1.0
9 participants