Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libmysql] Update to 8.0.20 #11303

Merged
merged 3 commits into from
May 15, 2020
Merged

[libmysql] Update to 8.0.20 #11303

merged 3 commits into from
May 15, 2020

Conversation

NancyLi1013
Copy link
Contributor

@NancyLi1013 NancyLi1013 commented May 11, 2020 •
edited
Loading

Update libmysql to the latest version 8.0.20 and also fix the error build on Linux.

Fix #11293
Fix #11145

Other changes:

  • Remove unused patches and options.
  • Add the option -DFORCE_UNSUPPORTED_COMPILER=1 to skip the version check for Visual Studio.
  • Remove the dependency of liblzma.
  • Please refer to this doc to learn more about the changes.

Note: No feature need to test.

@NancyLi1013 NancyLi1013 added the info:internal This PR or Issue was filed by the vcpkg team. label May 11, 2020
@NancyLi1013 NancyLi1013 mentioned this pull request May 11, 2020
Closed
@NancyLi1013 NancyLi1013 marked this pull request as ready for review May 11, 2020 13:59
@NancyLi1013
Copy link
Contributor Author

The regression for libodb-mysql :

C:\agent\_work\1\s\installed\x64-windows\include\odb/exception.hxx(19): note: see declaration of 'odb::exception'
C:\agent\_work\1\s\installed\x64-windows\include\mysql\mysql.h(639): error C2371: 'MYSQL_BIND': redefinition; different basic types
C:\agent\_work\1\s\buildtrees\libodb-mysql\src\db-mysql-2-68ab16ec77\odb/mysql/mysql-types.hxx(11): note: see declaration of 'MYSQL_BIND'

NancyLi1013 added 2 commits May 12, 2020 02:49
Fix the redefinition'MYSQL_BIND' between libmysql and libodb-mysql
262a6ca
Merge branch 'master' of https://github.com/Microsoft/vcpkg into dev/…
1116df2 
…NancyLi/update-libmysql

# Conflicts:
#	ports/libmysql/CONTROL
#	ports/libmysql/portfile.cmake
@JackBoosY JackBoosY self-requested a review May 15, 2020 09:25
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label May 15, 2020
@strega-nil
Copy link
Contributor

Cool, thanks @NancyLi1013 :)

@strega-nil strega-nil merged commit 184c724 into microsoft:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[libmysql] update to 8.0.20 [libmysql] build failure fedora 31
3 participants
@NancyLi1013 @strega-nil @JackBoosY