Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[basisu, gppanel, msgpack11, nana, rapidcheck, folly] Add missing header file of STL #11494

Merged
merged 1 commit into from
May 27, 2020

Conversation

LilyWangL
Copy link
Contributor

Describe the pull request

  • What does your PR fix?
    Since an internal change, doesn't transitively include, then these ports build failed like the following error.
    folly\src\46d6707604-d64234cbb5\folly/lang/Bits.h(71): error C2039: 'bit_cast': is not a member of 'std'
    gppanel\src\eeef051b25-b2b3e8579b\gpPanel\mpScaleY.cpp(146): error C2039: 'fabs': is not a member of 'std'
    For fixing these issues, just need to add the missing header file into the source.

@LilyWangL LilyWangL added the info:internal This PR or Issue was filed by the vcpkg team. label May 21, 2020
@LilyWangL LilyWangL requested a review from Cheney-W May 21, 2020 10:15
@Cheney-W Cheney-W marked this pull request as ready for review May 22, 2020 02:00
@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Cheney-W Cheney-W added info:reviewed Pull Request changes follow basic guidelines category:port-bug The issue is with a library, which is something the port should already support labels May 22, 2020
@BillyONeal
Copy link
Member

I believe this is a 16.6 fix.

@dan-shaw dan-shaw merged commit 4694b88 into microsoft:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants