-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg] Add a schema file for vcpkg.json #12178
Conversation
Per json schema, having any other field in a `{ "$ref": ""}` object is invalid.
Also, if that path ends up being the final one, an id field should be added with and url providing the schema, either the github raw one, or something else: {
"$schema": "http://json-schema.org/draft-07/schema#",
"$id": "https://raw.githubusercontent.com/microsoft/vcpkg/master/scripts/vcpkg.schema.json",
...
} |
I think that this is really good, the only thing I see is that it would be good to make the definitions match the spec: |
I wondered wether too do that or use the conventional json casing. I'll change the case when I have some time |
done, all definitions are now with-dashes. I kept description as |
@edhebi did you intend to mark this as ready to merge instead of a draft? |
@ras0219 oops, my bad. I'll mark it as ready to merge |
Thanks so much @edhebi! |
Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
This is related to #12175 .
This is absolutely not as tested as it should be, but I'm not sure how to go about it. I gess some set of known valid and known invalid manifest files would be required.
I choose the path an filename fairly arbitrarily, feel free to move it around.