[cuda] correct env variables for newer cuda versions

[Neumann-A]

A bit of version updating for newer cuda versions

[JackBoosY]

Does this PR fixes #11976?

[Neumann-A]

@JackBoosY: At least for me:

Starting package 1/19: cuda:x86-windows
Building package cuda[core]:x86-windows...
-- Found CUDA V11.0.167
-- Performing post-build validation
-- Performing post-build validation done
Building package cuda[core]:x86-windows... done
Installing package cuda[core]:x86-windows...
Installing package cuda[core]:x86-windows... done

[JackBoosY]

CUDA worked very well in the past, so I think this is caused by CUDA or findCUDA.cmake update. Do we need to judge based on the version of CUDA?

[Neumann-A]

I think it is related to updating visual studio which somehow wipes CUDA_PATH
After upgrading CUDA to 11 I got the following env vars now:

CUDA_PATH=C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0
CUDA_PATH_V10_2=C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v10.2
CUDA_PATH_V11_0=C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0

CUDA also worked for me two months or so ago and suddenly broke. So it is highly likely that a VS upgrade removed CUDA_PATH and only left the versioned CUDA_PATH_V_XX_X.

[JackBoosY]

Anyway, this changes LGTM.

[MVoz]

new rules are now in effect)) CONTROL file

Version: 10.1-2

Version: 10.1
Port-Version: 2

[Neumann-A]

@JackBoosY: We might need to define CUDA_PATHS on a more global level so that dependent ports can actually leverage the additional search paths but that is something for a different PR

[JackBoosY]

@Neumann-A think we should add it to vcpkg_common_definitions or add a vcpkg function to provide it.

[JackBoosY]

Let my colleague check this PR.
@ras0219 @ras0219-msft

[cenit]

CUDA_PATH should suffice tbh and it is working for cuda 11 for me without this PR :/ (and I also have vs fully up to date...)

[Neumann-A]

Another possibility is that a Windows Update killed the CUDA_PATH environment variable. Something remove it. nvcc was still on path for me so the PATH variable has not been touched

[BillyONeal]

The version check here looks bogus and we are still looking for a better way to publish the detected CUDA information for other ports, so I think we should merge this as is but we don't want to close the door on fixing that the right way.

Also this version check looks wrong https://github.com/microsoft/vcpkg/pull/12244/files#diff-efb436f7552399e0b189b636d44230f0R81

[cenit]

I remain on my idea that CUDA_PATH has to be defined in an environment for CUDA to be really working. It does not matter that this PR looks like fixing something, it’s just hiding problems which will reappear downwards. So, I would have left only CUDA_PATH for finding cuda. But again, it’s already merged, so be it.
The mood might be because today’s round of updates broke many ports on me, maybe...

[StarGate-One]

@Neumann-A I lost CUDA 11 (along with some other VS extension) in both my VS2017 and VS2019 with the latest upgrades of VS. I had to reinstall the CUDA package to get it back in both versions.
I do not know why some VS upgrades (especially like a 16.6.3 to 16.6.4) wipe out some extensions but keep others????