-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[triplets][osx] add support for arm64 'apple silicon' #12259
Conversation
Since Apple has announced they will be transitioning all Macs to Apple Silicon, I think this triplet would merit "official" status. (Or, in the event that a universal multi-arch Mac triplet is doable, said triplet that supports arm64 should merit "official" status.) IMHO. |
I think it should be important to be aggressive on this side and quick start ASAP to fix libraries for arm64-osx By the way, OSX too is deprecated, so maybe it can be arm64-macos. BigSur will be macOS 11.0, after what, 20 years of OSX (meaning v10.x, since the naming change already happened few years ago to macOS)? |
We do plan to make this an official triplet, however we do not want to add it to the official list until we have support in CI. If you'd like to modify this PR to add it to the community list we can merge it now, otherwise we can leave this open until we get CI support. |
LGTM, is this ready for merging? |
Is it really ok to use osx in the name? I know it might break more than expected (it’s not only cosmetic), but it’s not osx anymore for sure when targeting arm64... |
@cenit I know you're trying to be pedantic here, but I think switching osx to macos might break automated tools that depend on the original naming. For now I think it should align with the x64 name, and that today is osx. I agree though that once they make it an official triplet, it might be worth forking to macos at that point and should be a separate PR. |
@ras0219 yes! Go for it! |
Thanks!
For posterity, this is our thinking as well. |
You are right, too. |
This adds baseline support for building on arm64 "apple silicon" macs
What does your PR fix? Fixes Add arm64-osx triplet #12258
Does your PR follow the maintainer guide?
YES