Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[triplets][osx] add support for arm64 'apple silicon' #12259

Merged
merged 3 commits into from
Jul 7, 2020
Merged

[triplets][osx] add support for arm64 'apple silicon' #12259

merged 3 commits into from
Jul 7, 2020

Conversation

eklipse2k8
Copy link
Contributor

This adds baseline support for building on arm64 "apple silicon" macs

@past-due
Copy link
Contributor

past-due commented Jul 4, 2020

Since Apple has announced they will be transitioning all Macs to Apple Silicon, I think this triplet would merit "official" status. (Or, in the event that a universal multi-arch Mac triplet is doable, said triplet that supports arm64 should merit "official" status.) IMHO.

@cenit
Copy link
Contributor

cenit commented Jul 5, 2020

I think it should be important to be aggressive on this side and quick start ASAP to fix libraries for arm64-osx

By the way, OSX too is deprecated, so maybe it can be arm64-macos. BigSur will be macOS 11.0, after what, 20 years of OSX (meaning v10.x, since the naming change already happened few years ago to macOS)?

@JackBoosY JackBoosY added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Jul 6, 2020
@ras0219-msft
Copy link
Contributor

We do plan to make this an official triplet, however we do not want to add it to the official list until we have support in CI.

If you'd like to modify this PR to add it to the community list we can merge it now, otherwise we can leave this open until we get CI support.

@ras0219
Copy link
Contributor

ras0219 commented Jul 7, 2020

LGTM, is this ready for merging?

@cenit
Copy link
Contributor

cenit commented Jul 7, 2020

Is it really ok to use osx in the name? I know it might break more than expected (it’s not only cosmetic), but it’s not osx anymore for sure when targeting arm64...
(It’s not osTEN... it’s eleven!)

@eklipse2k8
Copy link
Contributor Author

Is it really ok to use osx in the name? I know it might break more than expected (it’s not only cosmetic), but it’s not osx anymore for sure when targeting arm64...
(It’s not osTEN... it’s eleven!)

@cenit I know you're trying to be pedantic here, but I think switching osx to macos might break automated tools that depend on the original naming. For now I think it should align with the x64 name, and that today is osx.

I agree though that once they make it an official triplet, it might be worth forking to macos at that point and should be a separate PR.

@eklipse2k8
Copy link
Contributor Author

LGTM, is this ready for merging?

@ras0219 yes! Go for it!

@ras0219-msft ras0219-msft merged commit aa6f70b into microsoft:master Jul 7, 2020
@ras0219-msft
Copy link
Contributor

Thanks!

For now I think it should align with the x64 name, and that today is osx. I agree though that once they make it an official triplet, it might be worth forking to macos at that point and should be a separate PR.

For posterity, this is our thinking as well.

@cenit
Copy link
Contributor

cenit commented Jul 7, 2020

Is it really ok to use osx in the name? I know it might break more than expected (it’s not only cosmetic), but it’s not osx anymore for sure when targeting arm64...

(It’s not osTEN... it’s eleven!)

@cenit I know you're trying to be pedantic here, but I think switching osx to macos might break automated tools that depend on the original naming. For now I think it should align with the x64 name, and that today is osx.

I agree though that once they make it an official triplet, it might be worth forking to macos at that point and should be a separate PR.

You are right, too.
There are many references to OSX in vcpkg. That’s better left for another PR, especially considering this triplet will be unofficial for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add arm64-osx triplet
7 participants