Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] Fix iOS toolchain detection when using the iOS community triplets #12361

Merged
merged 2 commits into from
Jul 13, 2020
Merged

[vcpkg] Fix iOS toolchain detection when using the iOS community triplets #12361

merged 2 commits into from
Jul 13, 2020

Conversation

alcroito
Copy link
Contributor

No description provided.

@alcroito
[vcpkg ios] Fix detection of iOS toolchain (microsoft#6003)
7553f5d 
Added mapping of CMAKE_SYSTEM_NAME == iOS to the bundled iOS toolchain
file.

This fixes the "Unable to determine toolchain to use for
triplet arm64-ios with CMAKE_SYSTEM_NAME iOS" error.
@alcroito
[vcpkg ios] Set the CMake system processor for the simulator arches (m…
19aec1b 
…icrosoft#6003)

So it's consistent for all architectures.
@alcroito alcroito mentioned this pull request Jul 10, 2020
Merged
@LilyWangL LilyWangL self-assigned this Jul 13, 2020
@LilyWangL LilyWangL changed the title Fix iOS toolchain detection when using the iOS community triplets [vcpkg] Fix iOS toolchain detection when using the iOS community triplets Jul 13, 2020
@LilyWangL LilyWangL added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:reviewed Pull Request changes follow basic guidelines labels Jul 13, 2020
@ras0219-msft ras0219-msft merged commit f1fbee8 into microsoft:master Jul 13, 2020
@ras0219-msft
Copy link
Contributor

Thanks for the improvement!

strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
@alcroito
[vcpkg] Fix iOS toolchain detection when using the iOS community trip…
2d2d8c7 
…lets (microsoft#12361)

* [vcpkg ios] Fix detection of iOS toolchain (microsoft#6003)

Added mapping of CMAKE_SYSTEM_NAME == iOS to the bundled iOS toolchain
file.

This fixes the "Unable to determine toolchain to use for
triplet arm64-ios with CMAKE_SYSTEM_NAME iOS" error.

* [vcpkg ios] Set the CMake system processor for the simulator arches (microsoft#6003)

So it's consistent for all architectures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219 ras0219 ras0219 approved these changes

@LilyWangL LilyWangL LilyWangL approved these changes

Assignees

@LilyWangL LilyWangL

Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alcroito @ras0219-msft @ras0219 @LilyWangL