[pybind11] Update to v2.5.0 #12394
Merged
[pybind11] Update to v2.5.0 #12394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
NancyLi1013
suggested changes
Jul 13, 2020
ports/pybind11/portfile.cmake
Outdated
| file(INSTALL ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/pybind11/copyright) |
There was a problem hiding this comment.
Suggested change
| file(INSTALL ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/pybind11/copyright) | |
| file(INSTALL ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright) |
NancyLi1013
added
category:port-update
|
Hi @anand-bala |
|
Hey @NancyLi1013, I cleaned up the fmt changes and made the edits you suggested. |
|
LGTM, thanks for the update! |
NancyLi1013
added
info:reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Updates pybind11 to the latest stable version v2.5.0 from v2.4.3.
What does your PR fix? Fixes [pybind11] update to 2.5.0 #12371
Which triplets are supported/not supported? Have you updated the CI baseline?
Supports all the previously supported triplets (all), but have checked on personal x64-linux and x64-windows. No changed to the CI baseline.
Yes.