Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gamedev-framework] fix install path of *.cmake files #12680

Merged
merged 2 commits into from
Aug 5, 2020
Merged

[gamedev-framework] fix install path of *.cmake files #12680

merged 2 commits into from
Aug 5, 2020

Conversation

jube
Copy link
Contributor

@jube jube commented Aug 1, 2020

The port name (gamedev-framework) differs from the package name (gf). The cmake files were installed in the default directory (share/${PORT}) which prevented the use of the port as cmake searches the files in share/gf. The TARGET_PATH of vcpkg_fixup_cmake_targets handles this case.

Yes.

The port name (gamedev-framework) differs from the package name (gf).
@ghost
Copy link

ghost commented Aug 1, 2020

CLA assistant check
All CLA requirements met.

@PhoebeHui PhoebeHui self-assigned this Aug 3, 2020
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@PhoebeHui PhoebeHui added category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines labels Aug 3, 2020
@strega-nil strega-nil merged commit 1835605 into microsoft:master Aug 5, 2020
hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
* [gf] fix install path of *.cmake files

The port name (gamedev-framework) differs from the package name (gf).

* [gf] increase port version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants