[vcpkg baseline] remove qt translations from skip list #12699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackBoosY
suggested changes
Aug 3, 2020
There was a problem hiding this comment.
Please update the qt5-translations version info. See documentation.
|
@JackBoosY Why? This is an internal change only which does not change the hash of the port and CI also correctly rerun the build for x64-windows-static according to the logs. I cannot see any reason to generate a commit for x-history or force a rebuild for users. |
JackBoosY
added
info:reviewed
JackBoosY
approved these changes
Aug 3, 2020
JackBoosY
changed the title
ras0219
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the fix has already been merged