Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zlib, libpng] Fix pkg-config for mingw #12753

Merged
merged 2 commits into from
Aug 10, 2020
Merged

[zlib, libpng] Fix pkg-config for mingw #12753

merged 2 commits into from
Aug 10, 2020

Conversation

longnguyen2004
Copy link
Contributor

Describe the pull request

  • What does your PR fix? Fixes #
    Fixes pkg-config for mingw, since there's no d in the library name
  • Which triplets are supported/not supported? Have you updated the CI baseline?
    All mingw triplets
  • Does your PR follow the maintainer guide?
    Yes

Neumann-A
Neumann-A reviewed Aug 5, 2020
View reviewed changes
ports/zlib/portfile.cmake Outdated Show resolved Hide resolved
@longnguyen2004 longnguyen2004 changed the title [zlib] Fix pkg-config for mingw [zlib, libpng] Fix pkg-config for mingw Aug 5, 2020
@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Aug 5, 2020
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Aug 10, 2020
@strega-nil strega-nil merged commit fca18ba into microsoft:master Aug 10, 2020
@longnguyen2004 longnguyen2004 deleted the zlib-pkgconfig branch August 11, 2020 04:01
@longnguyen2004 longnguyen2004 mentioned this pull request Aug 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neumann-A Neumann-A Neumann-A left review comments

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@longnguyen2004 @PhoebeHui @Neumann-A @strega-nil @JackBoosY