Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libsndfile] Update to 1.0.29 #12921

Merged
merged 3 commits into from
Aug 26, 2020
Merged

[libsndfile] Update to 1.0.29 #12921

merged 3 commits into from
Aug 26, 2020

Conversation

evpobr
Copy link
Contributor

@evpobr evpobr commented Aug 15, 2020

Updates:

  • Bump to official 1.0.29 release
  • Two Git patches removed as merged to upstream
  • Request Python3 when building shared library to generate export symbol files
  • CONTROL replaced by vcpkg.json
  • Removed BUILD_EXECUTABLES code. It was always OFF anyway
  • Use new options instead of deprecated ones

Important note: target name is changed toSndFile::sndfile from upstream.

@NancyLi1013 NancyLi1013 added the category:port-update The issue is with a library, which is requesting update new revision label Aug 17, 2020
@evpobr evpobr marked this pull request as draft August 17, 2020 07:04
@evpobr
Copy link
Contributor Author

evpobr commented Aug 17, 2020

Don't understand why Python is not found.

@LilyWangL LilyWangL marked this pull request as ready for review August 19, 2020 06:37
@evpobr
Copy link
Contributor Author

evpobr commented Aug 19, 2020

Thanks @LilyWangL 😄

@evpobr
Copy link
Contributor Author

evpobr commented Aug 24, 2020

@LilyWangL , this PR is ready.

@LilyWangL LilyWangL added the info:reviewed Pull Request changes follow basic guidelines label Aug 25, 2020
@BillyONeal
Restore port-version and bump to 11.
3c9ac33
@BillyONeal
Use vcpkg_check_features.
09789d4 
I checked for "-DENABLE_EXTERNAL_LIBS=ON" and "-DENABLE_EXTERNAL_LIBS=ON" according to the feature setting.
evpobr
evpobr commented Aug 25, 2020
View reviewed changes
Copy link
Contributor Author

@evpobr evpobr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BillyONeal , it is final 1.0.29 release.

@BillyONeal
Copy link
Member

@evpobr: Yes, but the old one was marked 1.0.29-10 and we want the version number to be increasing over time (assuming the upstream is going forward over time)

@BillyONeal
Copy link
Member

(Note that our version-portversion convention in the CONTROL files was not semver)

@BillyONeal BillyONeal merged commit fd7e280 into microsoft:master Aug 26, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyWangL LilyWangL LilyWangL approved these changes

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees

@LilyWangL LilyWangL

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@evpobr @BillyONeal @LilyWangL @NancyLi1013