Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sentry-native] Add new port #13118

Merged
merged 4 commits into from
Sep 1, 2020
Merged

[sentry-native] Add new port #13118

merged 4 commits into from
Sep 1, 2020

Conversation

AenBleidd
Copy link
Contributor

This fixes #12159

Signed-off-by: Vitalii Koshura lestat.de.lionkur@gmail.com

@AenBleidd
[sentry-native] Add new port
dbc87e2 
This fixes microsoft#12159

Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
@NancyLi1013 NancyLi1013 self-assigned this Aug 25, 2020
@NancyLi1013 NancyLi1013 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Aug 25, 2020
NancyLi1013
NancyLi1013 suggested changes Aug 25, 2020
View reviewed changes
ports/sentry-native/CONTROL Outdated Show resolved Hide resolved
ports/sentry-native/portfile.cmake Outdated Show resolved Hide resolved
ports/sentry-native/portfile.cmake Show resolved Hide resolved
ports/sentry-native/portfile.cmake Outdated Show resolved Hide resolved
ports/sentry-native/portfile.cmake Outdated Show resolved Hide resolved
@AenBleidd
Fix review findings
1b128e5 
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
@NancyLi1013
Copy link
Contributor

Hi @AenBleidd
Thanks for this PR.

Could you please look into the failures and try to fix them?

If this port doesn't support arm and uwp, please add Supports: !(arm|uwp) to CONTROL file and also add vcpkg_fail_port_install_port(ON_ARCH "arm" ON_TARGET "uwp") to the top of portfile.cmake.

NancyLi1013
NancyLi1013 suggested changes Aug 25, 2020
View reviewed changes
ports/sentry-native/portfile.cmake Outdated Show resolved Hide resolved
@AenBleidd
Fix linux build
a61dd8f 
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
@AenBleidd
Remove unsupported archs
a439270 
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
@AenBleidd
Copy link
Contributor Author

@NancyLi1013, PR is ready for your review

@AenBleidd AenBleidd marked this pull request as ready for review August 27, 2020 02:26
@AenBleidd
Copy link
Contributor Author

CI fail is not related to this PR: previous build was successful: https://dev.azure.com/vcpkg/public/_build/results?buildId=42093&view=results
tiny-xml is failed but definitely not because of this PR

@AenBleidd AenBleidd marked this pull request as draft August 27, 2020 02:44
@AenBleidd AenBleidd marked this pull request as ready for review August 27, 2020 02:44
@NancyLi1013
Copy link
Contributor

@AenBleidd
Thanks for your kindly reminder.
The failures are not related with this PR. There are some problems on Sourceforge website. We have submitted a PR #13176 to detect Sourceforge website status.

@AenBleidd AenBleidd marked this pull request as draft August 27, 2020 20:48
@AenBleidd AenBleidd marked this pull request as ready for review August 27, 2020 20:48
@AenBleidd
Copy link
Contributor Author

@NancyLi1013, after rebuild it's officially green :)

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Aug 31, 2020
@NancyLi1013
Copy link
Contributor

@AenBleidd
Thanks for this PR. LGTM now.

@BillyONeal BillyONeal merged commit b1bdebe into microsoft:master Sep 1, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

@AenBleidd AenBleidd deleted the add_entry-native_port branch September 1, 2020 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Port Request] sentry-native
3 participants
@AenBleidd @NancyLi1013 @BillyONeal