Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libxmlmm ] Add new port libxmlmm 0.6.0 #13139

Merged
merged 3 commits into from
Sep 1, 2020
Merged

[libxmlmm ] Add new port libxmlmm 0.6.0 #13139

merged 3 commits into from
Sep 1, 2020

Conversation

rioki
Copy link
Contributor

@rioki rioki commented Aug 25, 2020

Describe the pull request

  • What does your PR fix? Fixes #

Adds libxmlmm in version 0.6.0

  • Which triplets are supported/not supported? Have you updated the CI baseline?

Known good triplets:
x86-windows
x64-windows
x64-linux

The code is quite portable and most should be suported.

I checked and hope I did all right.

@ghost
Copy link

ghost commented Aug 25, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@NancyLi1013 NancyLi1013 self-assigned this Aug 26, 2020
@NancyLi1013 NancyLi1013 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Aug 26, 2020
NancyLi1013
NancyLi1013 suggested changes Aug 26, 2020
View reviewed changes
ports/libxmlmm/portfile.cmake Outdated Show resolved Hide resolved
ports/libxmlmm/CMakeLists.txt Outdated Show resolved Hide resolved
ports/libxmlmm/CMakeLists.txt Outdated Show resolved Hide resolved
@NancyLi1013 NancyLi1013 changed the title Add libxmlmm 0.6.0 [libxmlmm ] Add new port libxmlmm 0.6.0 Aug 26, 2020
@rioki
Copy link
Contributor Author

rioki commented Aug 26, 2020 •
edited
Loading

Do you want to squash the change into one clean commit?

@rioki rioki requested a review from NancyLi1013 August 26, 2020 18:04
NancyLi1013
NancyLi1013 suggested changes Aug 27, 2020
View reviewed changes
ports/libxmlmm/portfile.cmake Outdated Show resolved Hide resolved
@NancyLi1013
Copy link
Contributor

Hi @rioki
Thanks for this PR.
There is no need to squash the change into one clean commit.
The current status looks good.

Is there anything need to be done on your sides?

@NancyLi1013 NancyLi1013 marked this pull request as ready for review August 28, 2020 08:22
@rioki
Copy link
Contributor Author

rioki commented Aug 30, 2020

Thank you for your assistance.

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Aug 31, 2020
@NancyLi1013
Copy link
Contributor

LGTM now. Thanks for your hard work.

@BillyONeal BillyONeal merged commit 2045a0e into microsoft:master Sep 1, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

@rioki rioki deleted the libxmlmm branch September 1, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rioki @NancyLi1013 @BillyONeal