[taskflow] Update cpp-taskflow 2.2.0 to taskflow 2.6.0

[mfornace]

Describe the pull request

Bug fix to previous pull request updating cpp-taskflow to 2.5.0.

• What does your PR fix? Fixes #

Library name is now changed to "taskflow." Target can be found correctly.

• Which triplets are supported/not supported? Have you updated the CI baseline?

All of them, none have been updated.

• Does your PR follow the maintainer guide?

Yes

[BillyONeal]

Unfortunately this breaks vcpkg upgrade.... we might want to keep it using the old name in the ports tree. Will ask other maintainers about it.

Also you've got some merge conflicts :)

[mfornace]

@BillyONeal OK thanks, I fixed the conflicts (didn't see them the first time). CI passed with the new name change to Taskflow.

I then added a patch to configure the project as Cpp-Taskflow (just had to change the PROJECT() call pretty much). Then the config file names are appropriate and it can stay as cpp-taskflow. Not that painful...I guess.

Not sure what is best in terms of renaming the package or not; I guess both could work for now. It is a permanent name change mentioned on the Taskflow github FWIW. ¯\_(ツ)_/¯

Edit: I also don't know what the CI errors on the latest commit mean at all...

Cannot find path 'C:\a\1\a\xml-results\x64-windows.xml' because it does not exist

[JackBoosY]

Maybe we need to add a vcpkg-cmake-wrapper.cmake to solve this different. And for the msvc project, we can't do anything.

[JackBoosY]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[JackBoosY]

Please update the version info. See documentation.

[mfornace]

@JackBoosY I updated to 2.5.0-1, it still works locally as well for me to link to the Cpp-Taskflow::Cpp-Taskflow target. Not sure what you decided about changing the port name but it seems OK to me as is, for now.

[BillyONeal]

Not sure what you decided about changing the port name but it seems OK to me as is, for now.

We haven't discussed it yet.

I suspect we're either going to want a port left with the old name that depends on the current name, or we are going to not want to change the name at all.

To clarify, the scenario this breaks is:

:: some time a year ago
.\vcpkg.exe install cpp-taskflow
:: today
git pull
.\vcpkg upgrade --no-dry-run

[ras0219]

Renaming the library sounds good to me, plus having a forwarding port for some amount of time (the description should make it clear that it's deprecated).

[BillyONeal]

@mfornace OK, up to you. Can you indicate which of these you'd prefer:

• Leave the port named cpp-taskflow; I see you have since updated your changes to do this
• Rename the port to taskflow and add a new cpp-taskflow that does a message(WARNING "The port cpp-taskflow has been replaced with taskflow.") and a comment therein saying we'll remove it in ~6 months.

Thanks!

[remz1337]

@JackBoosY is there anything pending to approve this PR?
Thanks

[BillyONeal]

@remz1337 I wanted to give @mfornace the opportunity to pursue the alias solution if they desired since we had landed on that being OK; #13140 (comment)

If we get no response by... let's say tomorrow, we'll probably merge as is.

[mfornace]

Sorry, I lost track of this issue. I suppose I have no strong feeling on renaming the port... it is not a repo I am involved in, I should say. It seems for sure easier for us to leave the port as is (cpp-taskflow). The problem is anyone migrating (like me) to using vcpkg with Taskflow would have to change their CMake files for the different target name that is exported, so that's not a great solution.

To pursue the other solution, would we just include the current master version of cpp-taskflow with a warning, and then include the taskflow port I originally submitted as the PR?

If you agree with the latter solution, I can:

• roll back the PR to leaving cpp-taskflow except for including message(WARNING "The port cpp-taskflow has been replaced with taskflow.")
• roll back the PR to my original commit which just exports Taskflow::Taskflow, except now that content goes in the taskflow folder

And sorry for the dumb question, but how do you mark the change as resolved? :D

[JackBoosY]

@mfornace git reset <COMMIT_ID>

[mfornace]

Edited to 2.5.0-1

[mfornace]

Sorry, I'm a bit clueless on the vcpkg PR process, but here's what I did:

• Edited the cpp-taskflow port back to how it was before the whole PR, then updated to 2.4.0 (the most recent non-renamed version). This prevents the port from breaking on OS X, which was my original purpose in all this T_T (this is just a bug in cpp-taskflow's cmake at that time). Then I patched it a bit to disable building the examples since it is header-only.
• Made a new taskflow port for new version 2.6.0 (released since PR was started), which fixes some of the 2.5.0 issues. I fixed the installation of the CMake files and added the minor MSVC patch.

From what I can tell, the CI fails because cpp-taskflow and taskflow install the same files (e.g. taskflow/**.h in both cases). I tested both locally and they worked in installation and linking to a dummy project (but they can't be installed at the same time).

I would appreciate some help on how to arrange the port(s) etc so that CI can pass correctly.

[BillyONeal]

Unfortunately your changes here downgrade the cpp-taskflow port which is likely the cause of the failures here. Since you wanted the 'alias' solution I pushed changes that do that.

[mfornace]

I removed the compiler patch file and edited the port to use vcpkg_fixup_cmake_targets.

[ras0219-msft]

Thanks for the PR!