Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sentry-native] Update to 0.4.1 #13305

Merged
merged 2 commits into from
Sep 7, 2020
Merged

[sentry-native] Update to 0.4.1 #13305

merged 2 commits into from
Sep 7, 2020

Conversation

AenBleidd
Copy link
Contributor

Signed-off-by: Vitalii Koshura lestat.de.lionkur@gmail.com

@AenBleidd
[sentry-native] Update to 0.4.1
d6e8ca1 
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
@AenBleidd AenBleidd marked this pull request as draft September 2, 2020 16:03
@AenBleidd AenBleidd marked this pull request as ready for review September 2, 2020 16:03
@LilyWangL LilyWangL added the category:port-update The issue is with a library, which is requesting update new revision label Sep 3, 2020
@AenBleidd
Copy link
Contributor Author

@LilyWangL, CI for OSX is failed but because of different port that is not related to this PR.

@AenBleidd AenBleidd marked this pull request as draft September 3, 2020 18:20
@AenBleidd AenBleidd marked this pull request as ready for review September 3, 2020 18:20
@AenBleidd
Copy link
Contributor Author

Now it fails on linux on non-related package.
Why it's necessary to rebuild almost all packages in port PR that are not related (and even not dependencies of this port and not depended on it) to the port that is actually changed in PR? It's a waste of time

@AenBleidd
Merge branch 'master' of github.com:microsoft/vcpkg into sentry-nativ…
80f57fc 
…e_update_to_041

Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>

# Conflicts:
#	ports/sentry-native/CONTROL
@LilyWangL LilyWangL added the info:reviewed Pull Request changes follow basic guidelines label Sep 7, 2020
@BillyONeal
Copy link
Member

@AenBleidd The PR system builds the "cone of destruction" by forming a hash tree of all the inputs of all the ports in the system, comparing those hashes with the binary cache, and rebuilding everything the binary cache doesn't know about. So it might build more stuff if we recently had to blow away the binary cache for some reason, or recently merged something with master that triggers effectively a full rebuild (like an edit to $/scripts/buildsystems/vcpkg.cmake)

Thanks for your contribution!

@BillyONeal BillyONeal merged commit c295c35 into microsoft:master Sep 7, 2020
@AenBleidd AenBleidd deleted the sentry-native_update_to_041 branch September 7, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyWangL LilyWangL LilyWangL approved these changes

Assignees

@LilyWangL LilyWangL

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AenBleidd @BillyONeal @LilyWangL