Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rappture] Add new port #13321

Merged
merged 4 commits into from
Sep 5, 2020
Merged

[rappture] Add new port #13321

merged 4 commits into from
Sep 5, 2020

Conversation

AenBleidd
Copy link
Contributor

Signed-off-by: Vitalii Koshura lestat.de.lionkur@gmail.com

@AenBleidd
[rappture] Add new port
28df08e 
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
@JackBoosY JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Sep 3, 2020
BillyONeal
BillyONeal reviewed Sep 3, 2020
View reviewed changes
ports/rappture/portfile.cmake Outdated Show resolved Hide resolved
ports/rappture/CMakeLists.txt Show resolved Hide resolved
ports/rappture/CMakeLists.txt Outdated Show resolved Hide resolved
strega-nil
strega-nil suggested changes Sep 3, 2020
View reviewed changes
ports/rappture/CMakeLists.txt Outdated Show resolved Hide resolved
ports/rappture/CMakeLists.txt Outdated Show resolved Hide resolved
@AenBleidd
[rappture] Fix review findings
df57903 
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
@AenBleidd
Copy link
Contributor Author

@JackBoosY, @strega-nil, @BillyONeal, all comments are fixed. Please make review again. Thanks in advance

JackBoosY
JackBoosY suggested changes Sep 4, 2020
View reviewed changes
ports/rappture/CMakeLists.txt Outdated Show resolved Hide resolved
ports/rappture/portfile.cmake Show resolved Hide resolved
ports/rappture/rappture.patch Outdated Show resolved Hide resolved
@AenBleidd
[rappture] Make library static-only
1bd1b8b 
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
@AenBleidd
Copy link
Contributor Author

@JackBoosY, all comments are fixed

strega-nil
strega-nil approved these changes Sep 4, 2020
View reviewed changes
Copy link
Contributor

@strega-nil strega-nil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! I think just the export names need to change, so that someone can find this library via find_package :)

ports/rappture/CMakeLists.txt Outdated Show resolved Hide resolved
ports/rappture/CMakeLists.txt Outdated Show resolved Hide resolved
@AenBleidd
[rappture] Fix exports
d76a6c7 
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
@BillyONeal BillyONeal merged commit 2e110d2 into microsoft:master Sep 5, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

@AenBleidd AenBleidd deleted the vko_add_port_rappture branch September 5, 2020 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil strega-nil strega-nil approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

@BillyONeal BillyONeal Awaiting requested review from BillyONeal

Assignees

@JackBoosY JackBoosY

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AenBleidd @BillyONeal @strega-nil @JackBoosY