Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sentry-native] Fix build failure and cmake path #13329

Merged

Conversation

JackBoosY
Copy link
Contributor

When building sentry-native on Windows, the compiler sometimes reports some errors:

D:\buildtrees\sentry-native\src\try-native-a1d92af944.clean\src\../vendor/mpack.h(2113): warning C4013: '_Static_assert' undefined; assuming extern returning int
mpack.c.obj : error LNK2019: unresolved external symbol _Static_assert referenced in function mpack_writer_init_growable

This is because MPACK_STATIC_ASSERT is not correctly defined as static_assert.
Fix this issue and fix the generated cmake files path.

Related: #12612.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Sep 3, 2020
@JackBoosY
Copy link
Contributor Author

Perhaps some ports polluted the definition of the macro MPACK_STATIC_ASSERT, which caused the issue.
If so, this modification will be invalid.

@BillyONeal
Copy link
Member

Maybe we should do something like BillyONeal@4f042be instead?

@BillyONeal
Copy link
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants