Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OpenMVS] fix OpenMP feature on linux for downstream projects #13330

Merged
merged 1 commit into from
Sep 28, 2020
Merged

[OpenMVS] fix OpenMP feature on linux for downstream projects #13330

merged 1 commit into from
Sep 28, 2020

Conversation

cenit
Copy link
Contributor

@cenit cenit commented Sep 3, 2020

If OpenMP feature is enabled in OpenMVS, downstream projects have problems linking to OpenMVS in linux.
With this PR the problem is fixed

@cenit
Copy link
Contributor Author

cenit commented Sep 3, 2020

why CI is not testing openmvs:x64-linux? It should build without errors, but here it's flagged as "cascade" failure

@NancyLi1013 NancyLi1013 self-assigned this Sep 4, 2020
@NancyLi1013
Copy link
Contributor

Since openmvs depends on cgal, cgal also shows cascade in CI. cgal depends on mpir. mpir is set as skip in ci.baseline.txt due to conflicts with gmp.

If the dependency is set as fail or skip in ci.baseline.txt, the test result for this port will show cascade in CI.

@NancyLi1013 NancyLi1013 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Sep 4, 2020
@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Sep 8, 2020 •
edited
Loading

All features have passed with the following triplets:

  • x86-windows
  • x64-windows-static

Note: Feature cuda is blocked on x64-linux, since there is no cuda installed on my local machine.
Feature openmp is blocked on x64-linux due to no space left on device.

@cenit Could you please help test these two features on x64-linux?

@cenit
Copy link
Contributor Author

cenit commented Sep 24, 2020 •
edited
Loading

Works here for me on linux
Sorry I didn’t see your question. Any other thing to consider for merging?

@NancyLi1013 NancyLi1013 removed the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Sep 25, 2020
@NancyLi1013
Copy link
Contributor

LGTM now. Thanks for your updates.

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Sep 25, 2020
@ras0219-msft ras0219-msft merged commit ed26fc6 into microsoft:master Sep 28, 2020
@ras0219-msft
Copy link
Contributor

LGTM, thanks for the fix!

@cenit cenit deleted the dev/cenit/openmvs_openmp branch September 29, 2020 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cenit @NancyLi1013 @ras0219-msft