-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libsigcpp-3] Add new port #13412
Merged
Merged
[libsigcpp-3] Add new port #13412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilyWangL
added
the
category:new-port
The issue is requesting a new library to be added; consider making a PR!
label
Sep 9, 2020
LilyWangL
approved these changes
Sep 9, 2020
ras0219-msft
requested changes
Sep 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Looks good to me once these comments are addressed.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@LilyWangL @ras0219-msft I think this pr is ready to merge. |
LilyWangL
added
info:reviewed
Pull Request changes follow basic guidelines
and removed
requires:author-response
labels
Sep 29, 2020
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:new-port
The issue is requesting a new library to be added; consider making a PR!
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does your PR fix? Fixes Add new port [libsigcpp-3] #13409 Fixes [New Port Request] libsigcpp-3 #13379
Does your PR follow the maintainer guide? yes
Submission containing materials of a third party: The libsigc++ Development Team under GPL-3.0 License