Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mp-units] add new port #13416

Merged
merged 2 commits into from
Sep 9, 2020
Merged

Conversation

Neumann-A
Copy link
Contributor

No description provided.

@JackBoosY JackBoosY self-assigned this Sep 9, 2020
@JackBoosY JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Sep 9, 2020
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Sep 9, 2020
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

vcpkg_fixup_cmake_targets(CONFIG_PATH lib/cmake/${PORT})
# Handle copyright/readme/package files
file(INSTALL ${SOURCE_PATH}/LICENSE.md DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright)
file(INSTALL ${SOURCE_PATH}/README.md DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
file(INSTALL ${SOURCE_PATH}/README.md DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT})

We do not generally install accessory documentation.

@ras0219-msft ras0219-msft merged commit aa042ad into microsoft:master Sep 9, 2020
@Neumann-A Neumann-A deleted the add-mp-units branch September 9, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants