[Many ports] Update to the latest version or commit #13560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NancyLi1013
added
info:internal
[libsync] Update patch format
JackBoosY
approved these changes
Sep 17, 2020
ras0219-msft
requested changes
Sep 21, 2020
|
|
||
| vcpkg_check_linkage(ONLY_STATIC_LIBRARY) | ||
|
|
||
| vcpkg_from_github( | ||
| OUT_SOURCE_PATH SOURCE_PATH | ||
| REPO librsync/librsync | ||
| REF v2.0.2 | ||
| SHA512 5d2bc1d62b37e9ed7416203615d0a0e3c05c4c884b5da63eda10dd5c985845b500331bce226e4d45676729382c85b41528282e25d491afda31ba434ac0fefad7 | ||
| REF d1938c387e86ab5bbf7cb2e84244229c5bbd5ebf # commit 2020-06-04 |
There was a problem hiding this comment.
We should use the latest release: https://github.com/librsync/librsync/releases/tag/v2.3.1
There was a problem hiding this comment.
There are some errors in the latest release, so I used the latest commit to update this port.
Such as
CMake Error at C:/Program Files/CMake/share/cmake-3.17/Modules/TestBigEndian.cmake:50 (message):
no suitable type found
Call Stack (most recent call first):
CMakeLists.txt:115 (TEST_BIG_ENDIAN)
Please see librsync/librsync#207
error C2491: 'rs_trace_to': definition of dllimport function not allowed
These two issues have been fixed in the latest commit.
NancyLi1013
removed
the
info:reviewed
|
pkgconfig for |
|
Revert |
JackBoosY
approved these changes
Sep 22, 2020
ras0219-msft
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ports to latest version and also fix build errors.
Update ci.baseline.txt
Related #13536
Note: There are many errors in the latest version for
librsync. So I updated it to the latest commit.