Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qt5] Install Qt5 Network SSL dependencies #13599

Merged
merged 17 commits into from
Sep 24, 2020
Merged

[qt5] Install Qt5 Network SSL dependencies #13599

merged 17 commits into from
Sep 24, 2020

Conversation

alexander-smyslov
Copy link
Contributor

  • What does your PR fix? Fixes #
    Copy SSL library when install QT App

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    windows-x64 windows-x86

  • Does your PR follow the maintainer guide?
    yes

@alexander-smyslov alexander-smyslov changed the title Qt5network [at5] Install Qt5 Network SSL dependencies Sep 18, 2020
@alexander-smyslov alexander-smyslov changed the title [at5] Install Qt5 Network SSL dependencies [qt5] Install Qt5 Network SSL dependencies Sep 18, 2020
ras0219
ras0219 approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@ras0219 ras0219 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

This makes a substantial enough change that it requires incrementing the Port-Version: of qt5-base

ports/qt5-base/qtdeploy.ps1 Outdated Show resolved Hide resolved
@JackBoosY
Copy link
Contributor

@Neumann-A Ping for review this PR.

@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Sep 22, 2020
@Neumann-A
Copy link
Contributor

@JackBoosY: From the file list in CI

openssl-windows:/bin/c_rehash.pl
openssl-windows:/bin/libcrypto-1_1-x64.dll
openssl-windows:/bin/libcrypto-1_1-x64.pdb
openssl-windows:/bin/libssl-1_1-x64.dll
openssl-windows:/bin/libssl-1_1-x64.pdb
openssl-windows:/bin/openssl.pdb
openssl-windows:/debug/bin/c_rehash.pl
openssl-windows:/debug/bin/libcrypto-1_1-x64.dll
openssl-windows:/debug/bin/libcrypto-1_1-x64.pdb
openssl-windows:/debug/bin/libssl-1_1-x64.dll
openssl-windows:/debug/bin/libssl-1_1-x64.pdb
openssl-windows:/debug/bin/openssl.pdb
openssl-windows:/debug/lib/libcrypto.lib
openssl-windows:/debug/lib/libssl.lib

so it seems ok

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Sep 23, 2020
@ras0219-msft ras0219-msft merged commit 7bc2ec2 into microsoft:master Sep 24, 2020
@ras0219-msft
Copy link
Contributor

LGTM, thanks for the fix!

@alexander-smyslov alexander-smyslov deleted the qt5network branch April 26, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

@ras0219 ras0219 ras0219 approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexander-smyslov @JackBoosY @Neumann-A @ras0219-msft @ras0219