Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[infoware] fix linking issues with non-release builds #13822

Merged
merged 1 commit into from
Oct 6, 2020
Merged

[infoware] fix linking issues with non-release builds #13822

merged 1 commit into from
Oct 6, 2020

Conversation

Ryan-rsm-McKenzie
Copy link
Contributor

Fixes a linking issue with non-release builds where cmake could not find anything other than the release .lib

Also converts the CONTROL file into a vcpkg.json

@PhoebeHui PhoebeHui self-assigned this Sep 30, 2020
@PhoebeHui PhoebeHui added the category:port-bug The issue is with a library, which is something the port should already support label Sep 30, 2020
PhoebeHui
PhoebeHui approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Sep 30, 2020
@BillyONeal BillyONeal merged commit 221ee43 into microsoft:master Oct 6, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ryan-rsm-McKenzie @BillyONeal @PhoebeHui