-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always accept = or space as delimiters when parsing common command line parameters. #13857
Conversation
Also rename $args to $testArgs because the former is a PowerShell builtin variable.
CI failed because repo.msys.org is down. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are a few of the things I've noticed, but the big thing I'd like to see is this working for options to commands. This isn't necessary for this first pass, however. The enum class
thing is a necessity before I approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see an enum class
over size_t
as the return of try_parse_argument_as_option()
; otherwise LGTM.
# Conflicts: # scripts/azure-pipelines/end-to-end-tests.ps1
@strega-nil Do you have an example command like you want to work for your more complete desired overhaul that doesn't work with the current state of this PR? Out of band you said |
@BillyONeal |
I tried it with the install command and that didn't work. But I didn't try with a manifest so that likely explains it ¯_(ツ)_/¯ |
Ah, yeah, it's a manifest-only option. |
…ne parameters. (microsoft#13857) Resolves microsoft#11456.
Resolves #11456.