Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[glew] Add dependency #13993

Merged
merged 2 commits into from
Oct 13, 2020
Merged

[glew] Add dependency #13993

merged 2 commits into from
Oct 13, 2020

Conversation

PhoebeHui
Copy link
Contributor

Fixes #13967

glew depends on opengl, add the dependency to glew.

@PhoebeHui PhoebeHui added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Oct 12, 2020
@PhoebeHui PhoebeHui marked this pull request as ready for review October 12, 2020 08:08
@PhoebeHui @NancyLi1013
Update ports/glew/portfile.cmake
460a60f 
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Oct 13, 2020
@dan-shaw dan-shaw merged commit d50a66f into microsoft:master Oct 13, 2020
@PhoebeHui PhoebeHui deleted the dev/Phoebe/glew branch October 22, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 left review comments

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[glew] build failure. error LNK2019: unresolved external symbol
3 participants
@PhoebeHui @NancyLi1013 @dan-shaw