Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[asio] update to v1.18.0 #14095

Closed
wants to merge 0 commits into from
Closed

[asio] update to v1.18.0 #14095

wants to merge 0 commits into from

Conversation

mathisloge
Copy link
Contributor

Describe the pull request

  • What does your PR fix?
    updates the library asio to version 1.18.0

  • Which triplets are supported/not supported? Have you updated the CI baseline? No

  • Does your PR follow the maintainer guide?
    hope so

@mathisloge mathisloge marked this pull request as ready for review October 17, 2020 22:01
@NancyLi1013 NancyLi1013 added the category:port-update The issue is with a library, which is requesting update new revision label Oct 19, 2020
ports/asio/portfile.cmake Outdated Show resolved Hide resolved
ports/asio/portfile.cmake Outdated Show resolved Hide resolved
@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013
Copy link
Contributor

Hi @mathisloge
Thanks for posting this issue.
The regressions caused by this changes are like this:

For restbed

D:\buildtrees\restbed\src\80d5d74d1e-eb47e978c1.clean\source\corvusoft\restbed\detail\socket_impl.cpp(56): error C2039: 'get_io_service': is not a member of 'asio::basic_stream_socket<asio::ip::tcp,asio::any_io_executor>'
D:\installed\x86-windows\include\asio/ip/tcp.hpp(82): note: see declaration of 'asio::basic_stream_socket<asio::ip::tcp,asio::any_io_executor>'
D:\buildtrees\restbed\src\80d5d74d1e-eb47e978c1.clean\source\corvusoft\restbed\detail\socket_impl.cpp(56): error C2672: 'std::make_shared': no matching overloaded function found
D:\buildtrees\restbed\src\80d5d74d1e-eb47e978c1.clean\source\corvusoft\restbed\detail\socket_impl.cpp(57): error C2039: 'get_io_service': is not a member of 'asio::basic_stream_socket<asio::ip::tcp,asio::any_io_executor>'
D:\installed\x86-windows\include\asio/ip/tcp.hpp(82): note: see declaration of 'asio::basic_stream_socket<asio::ip::tcp,asio::any_io_executor>'
D:\buildtrees\restbed\src\80d5d74d1e-eb47e978c1.clean\source\corvusoft\restbed\detail\socket_impl.cpp(57): error C2672: 'std::make_shared': no matching overloaded function found
D:\buildtrees\restbed\src\80d5d74d1e-eb47e978c1.clean\source\corvusoft\restbed\detail\socket_impl.cpp(125): error C2039: 'get_io_service': is not a member of 'asio::basic_stream_socket<asio::ip::tcp,asio::any_io_executor>'
D:\installed\x86-windows\include\asio/ip/tcp.hpp(82): note: see declaration of 'asio::basic_stream_socket<asio::ip::tcp,asio::any_io_executor>'
D:\buildtrees\restbed\src\80d5d74d1e-eb47e978c1.clean\source\corvusoft\restbed\detail\socket_impl.cpp(125): error C2530: 'io_service': references must be initialized
D:\buildtrees\restbed\src\80d5d74d1e-eb47e978c1.clean\source\corvusoft\restbed\detail\socket_impl.cpp(127): error C3536: 'io_service': cannot be used before it is initialized
D:\buildtrees\restbed\src\80d5d74d1e-eb47e978c1.clean\source\corvusoft\restbed\detail\socket_impl.cpp(448): error C2039: 'get_io_service': is not a member of 'asio::basic_stream_socket<asio::ip::tcp,asio::any_io_executor>'
D:\installed\x86-windows\include\asio/ip/tcp.hpp(82): note: see declaration of 'asio::basic_stream_socket<asio::ip::tcp,asio::any_io_executor>'
D:\buildtrees\restbed\src\80d5d74d1e-eb47e978c1.clean\source\corvusoft\restbed\detail\socket_impl.cpp(448): error C2530: 'io_service': references must be initialized
D:\buildtrees\restbed\src\80d5d74d1e-eb47e978c1.clean\source\corvusoft\restbed\detail\socket_impl.cpp(450): error C3536: 'io_service': cannot be used before it is initialized
D:\buildtrees\restbed\src\80d5d74d1e-eb47e978c1.clean\source\corvusoft\restbed\detail\socket_impl.cpp(597): error C2039: 'get_io_service': is not a member of 'asio::basic_stream_socket<asio::ip::tcp,asio::any_io_executor>'
D:\installed\x86-windows\include\asio/ip/tcp.hpp(82): note: see declaration of 'asio::basic_stream_socket<asio::ip::tcp,asio::any_io_executor>'
D:\buildtrees\restbed\src\80d5d74d1e-eb47e978c1.clean\source\corvusoft\restbed\detail\socket_impl.cpp(597): error C2530: 'io_service': references must be initialized
D:\buildtrees\restbed\src\80d5d74d1e-eb47e978c1.clean\source\corvusoft\restbed\detail\socket_impl.cpp(599): error C3536: 'io_service': cannot be used before it is initialized

For opendnp3

D:\buildtrees\opendnp3\src\2.3.2-0b9dada440.clean\cpp\libs\src\asiopal\SerialChannel.cpp(35): error C2039: 'get_io_context': is not a member of 'asio::io_context::strand'
D:\installed\x64-windows\include\asio/io_context.hpp(239): note: see declaration of 'asio::io_context::strand'
D:\buildtrees\opendnp3\src\2.3.2-0b9dada440.clean\cpp\libs\src\asiopal\SerialChannel.cpp(35): error C2512: 'asio::basic_serial_port<asio::any_io_executor>::basic_serial_port': no appropriate default constructor available

Could you please try to fix these regressions?

For opendnp3, the latest release seems fix this problem. You just need to update it. Please see dnp3/opendnp3#373
For restbed, the fix has not been merged to master yet. Please see Corvusoft/restbed#444

@mathisloge
Copy link
Contributor Author

Hi @NancyLi1013,
Thanks for the Feedback.

Both Regression should be fixed in its own pull request correct?

Should base these new pull requests on this pull request or base them on master?

@NancyLi1013
Copy link
Contributor

For opendnp3, just need to update to the latest release, which has included this fix.

For restbed, please update to the latest version and make a patch to fix this issue based on the pull request.

@mathisloge
Copy link
Contributor Author

mathisloge commented Oct 21, 2020

@NancyLi1013 i should have clarified this better. I mean if I have to create two new pull requests in vcpkg for the port updates and base these on the asio pull request or should I update both ports in the asio pull request?

@NancyLi1013
Copy link
Contributor

@NancyLi1013 i should have clarified this better. I mean if I have to create two new pull requests in vcpkg for the port updates and base these on the asio pull request or should I update both ports in the asio pull request?

Update these two ports in asio pull request. Just add the changes in this PR.

@mathisloge
Copy link
Contributor Author

okay, I've messed this up. After the rebase everything showed up as changed...
Opendp3 is fixed.

Should i close this PR and make a new clean PR?

@NancyLi1013
Copy link
Contributor

If you're not clear about how to revert the changes, it would be better to make a new PR to update these ports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants