Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[krabsetw] Add new port #14192

Merged
merged 3 commits into from
Oct 29, 2020
Merged

[krabsetw] Add new port #14192

merged 3 commits into from
Oct 29, 2020

Conversation

jrave
Copy link
Contributor

@jrave jrave commented Oct 24, 2020

Describe the pull request

  • What does your PR fix? Fixes #
    Adding new port for krabsetw

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    Windows (non UWP) triplets are supported. Other platforms not. CI baseline not updated.

  • Does your PR follow the maintainer guide?
    Yes

@jrave
Copy link
Contributor Author

jrave commented Oct 25, 2020

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 14192 in repo microsoft/vcpkg

@NancyLi1013 NancyLi1013 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Oct 26, 2020
@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@NancyLi1013 NancyLi1013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a header-only library?

ports/krabsetw/portfile.cmake Show resolved Hide resolved
ports/krabsetw/portfile.cmake Outdated Show resolved Hide resolved
ports/krabsetw/portfile.cmake Outdated Show resolved Hide resolved
@jrave
Copy link
Contributor Author

jrave commented Oct 26, 2020

Is this a header-only library?

Yes it is header-only

@jrave jrave marked this pull request as ready for review October 27, 2020 14:34
ports/krabsetw/vcpkg.json Outdated Show resolved Hide resolved
ports/krabsetw/portfile.cmake Show resolved Hide resolved
jrave and others added 2 commits October 28, 2020 16:24
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
@NancyLi1013
Copy link
Contributor

LGTM now, thanks for your PR @jrave.

@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Oct 29, 2020
@BillyONeal BillyONeal merged commit 743c21e into microsoft:master Oct 29, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

@jrave jrave deleted the krabsetw branch November 7, 2020 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants