-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[krabsetw] Add new port #14192
Merged
Merged
[krabsetw] Add new port #14192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Commenter does not have sufficient privileges for PR 14192 in repo microsoft/vcpkg |
NancyLi1013
added
the
category:new-port
The issue is requesting a new library to be added; consider making a PR!
label
Oct 26, 2020
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
NancyLi1013
reviewed
Oct 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a header-only library?
Yes it is header-only |
NancyLi1013
suggested changes
Oct 28, 2020
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
NancyLi1013
approved these changes
Oct 29, 2020
LGTM now, thanks for your PR @jrave. |
NancyLi1013
added
info:reviewed
Pull Request changes follow basic guidelines
and removed
requires:author-response
labels
Oct 29, 2020
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:new-port
The issue is requesting a new library to be added; consider making a PR!
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix? Fixes #
Adding new port for krabsetw
Which triplets are supported/not supported? Have you updated the CI baseline?
Windows (non UWP) triplets are supported. Other platforms not. CI baseline not updated.
Does your PR follow the maintainer guide?
Yes